aacgain 1.9 update

[ryandesign (Ryan Carsten Schmidt)]

aacgain 1.9 is out so the port should probably be updated.

Begin forwarded message:

From: "David Lasker" <dave@altosdesign.com>
Date: August 3, 2010 16:28:58 CDT
To: "'Samuli Suominen'" <ssuominen@gentoo.org>, <marillat@free.fr>, <toni@links2linux.de>, "'Miguel Angel Alvarez'" <maacruz@gmail.com>, "'Prakash Punnoor'" <prakashp@arcor.de>, <binguri@yahoo.it>, "'Wolf Wilke'" <wwilke@genion.de>, "'Ben Allison'" <benski@winamp.com>, <hardloaf@gmail.com>, <mp3gain@hotmail.com>, <macports-mgr@lists.macosforge.org>
Subject: [macports-mgr] aacgain 1.9 released

I have completed the next release of aacgain. Updated files are in the
mp3gain CVS repository on Sourceforge. 

This release incorporates the following changes:

1.Fixed a bug in mp4v2 which caused iTunes music video files to fail with
"not a valid mp4/m4a file" error.

2.Gives a more meaningful error message when attempting to process Apple
Lossless files (which are still not supported by aacgain).

3.Built with updated mp4v2 and faad2 code, which should build error-free on
modern Windows, Linux, and Mac systems.

4.Built with latest mp3gain version 1.5.2 sources checked into CVS, which
include id3v2 tag support.

5.MSVC++ solution and project files have been converted to Visual C++ 2010
Express Edition.

6.I now have access to both Linux and Mac systems, so I have modified
Prakash Punoor's Unix build scripts to work correctly with the latest code
changes. I have successfully built and tested aacgain on Ubuntu 10.04 and
Mac OS X 10.6.

In my previous email announcing the beta test of this release, I said:

A major change was made in the way the global_gain adjustments are made. In
previous releases, the global_gain fields in the track were edited
in-place.
This was done by subclassing some of the mp4v2 C++ implementation files. In
this
release, I create a new audio ('soun') track in the mp4 file, copy the
samples
from the old track to the new track with the global_gain fields modified,
then
delete the original track. This means that files with multiple tracks (i.e.
video files) might have the order of the tracks changed.

After much testing, I have removed that code and have gone back to
subclassing. I found many changes were being made to the track atoms (e.g.
removal of the mp4a.pinf atom tree). Although the resulting files played
correctly on everything I tested them on, I didn't feel comfortable with
that approach. So I have gone back to subclassing, which edits the existing
track data in-place.

See the aacgain home page http://altosdesign.com/aacgain for more info.

Dave

_______________________________________________
macports-mgr mailing list
macports-mgr@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-mgr

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

Updated files are in the mp3gain CVS repository on Sourceforge.

I double-checked with David who confirms that the project is not releasing tarballs anymore, so we'll switch the port to fetch from CVS.

[ryandesign (Ryan Carsten Schmidt)]

Nevermind: we weren't using David's tarballs anyway because the installation method he advocates is complicated (involves separately downloading sources for other projects). We had been using a repackaging of aacgain by Miguel Alvarez which includes all of that in one easy-to-install package. I asked Miguel if he will release a repackaging of 1.9, and he said he will, when he finds the time. So we should wait for that.

[tomasio@…]

Hey Miguel,

any chance you will do a repackage of 1.9 for macports any time? I would appreciate it ; )

[ryandesign (Ryan Carsten Schmidt)]

Replying to tomasio@…:

Hey Miguel,

any chance you will do a repackage of 1.9 for macports any time? I would appreciate it ; )

Miguel is not participating in this ticket. You'll have to email him directly and ask him. (See the forwarded email in the description of this ticket for his address.)

[dgonyier (Dwaine Gonyier)]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #38047.

[macports@…]

It looks like Miguel never created the 1.9 tar ball. Please consider using an alternative complete source like ​http://www.deb-multimedia.org/pool/main/a/aacgain/aacgain_1.9.orig.tar.gz or one of it's mirrors.

[macports@…]

Cc Me!

[JacksonIsaac (Jackson Isaac)]

Replying to macports@…:

It looks like Miguel never created the 1.9 tar ball. Please consider using an alternative complete source like ​http://www.deb-multimedia.org/pool/main/a/aacgain/aacgain_1.9.orig.tar.gz or one of it's mirrors.

I tried to update the port to v1.9 using your source but I get an error while building mp4v2 phase for some reason.

:msg:main --->  Computing dependencies for aacgain:debug:main Searching for dependency: mp4v2
:debug:main Found Dependency: receipt exists for mp4v2
:debug:main Searching for dependency: faad2
:debug:main Didn't find receipt, going to depspec regex for: faad2
:debug:main Changing to port directory: /Users/jacksonisaac/Development/macports-ports/audio/faad2
:debug:main OS darwin/17.5.0 (Mac OS X 10.13) arch i386
:debug:main adding the default universal variant
:debug:main Reading variant descriptions from /Users/jacksonisaac/Development/macports-ports/_resources/port1.0/variant_descriptions.conf
:debug:main Running callback portconfigure::add_automatic_compiler_dependencies
:debug:main Finished running callback portconfigure::add_automatic_compiler_dependencies
:debug:main Running callback portbuild::add_automatic_buildsystem_dependencies
:debug:main Finished running callback portbuild::add_automatic_buildsystem_dependencies
:debug:main faad2 has no conflicts
:debug:main Starting logging for faad2
:debug:main Executing org.macports.main (aacgain)
:debug:main dropping privileges: euid changed to 502, egid changed to 501.
:debug:main Skipping completed org.macports.fetch (aacgain)
:debug:main Privilege de-escalation not attempted as not running as root.
:debug:main Skipping completed org.macports.checksum (aacgain)
:debug:main Privilege de-escalation not attempted as not running as root.
:debug:main Skipping completed org.macports.extract (aacgain)
:debug:main Privilege de-escalation not attempted as not running as root.
:debug:main Skipping completed org.macports.patch (aacgain)
:debug:main Privilege de-escalation not attempted as not running as root.
:debug:main Skipping completed org.macports.configure (aacgain)
:debug:main Privilege de-escalation not attempted as not running as root.
:debug:build build phase started at Sun Apr  8 17:14:51 IST 2018
:notice:build --->  Building aacgain
:debug:build Executing org.macports.build (aacgain)
:debug:build Environment: 
:debug:build CC_PRINT_OPTIONS='YES'
:debug:build CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/.CC_PRINT_OPTIONS'
:debug:build CPATH='/opt/local/include'
:debug:build LIBRARY_PATH='/opt/local/lib'
:debug:build MACOSX_DEPLOYMENT_TARGET='10.13'
:info:build Executing:  cd "/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9" && /usr/bin/make -j4 -w all 
:debug:build system:  cd "/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9" && /usr/bin/make -j4 -w all 
:info:build make: Entering directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9'
:info:build Making all in mp3gain
:info:build make[1]: Entering directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain'
:info:build Making all in mpglibDBL
:info:build make[2]: Entering directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain/mpglibDBL'
:info:build /Applications/Xcode.app/Contents/Developer/usr/bin/make  all-am
:info:build make[3]: Entering directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain/mpglibDBL'
:info:build make[3]: Nothing to be done for `all-am'.
:info:build make[3]: Leaving directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain/mpglibDBL'
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain/mpglibDBL'
:info:build make[2]: Entering directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain'
:info:build make[2]: Nothing to be done for `all-am'.
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain'
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/mp3gain'
:info:build Making all in aacgain
:info:build make[1]: Entering directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/aacgain'
:info:build /usr/bin/clang++ -DHAVE_CONFIG_H  -I../mp4v2/include -I../mp4v2 -I../faad2/libfaad -I../faad2/include -I../mp3gain  -I/opt/local/include  -pipe -Os -stdlib=libc++ -arch x86_64 -MT aacgain.o -MD -MP -MF .deps/aacgain.Tpo -c -o aacgain.o aacgain.cpp
:info:build /usr/bin/clang -DHAVE_CONFIG_H  -I../mp4v2/include -I../mp4v2 -I../faad2/libfaad -I../faad2/include -I../mp3gain  -I/opt/local/include  -pipe -Os -DHAS_LRINTF -arch x86_64 -MT decoder.o -MD -MP -MF .deps/decoder.Tpo -c -o decoder.o decoder.c
:info:build /usr/bin/clang -DHAVE_CONFIG_H  -I../mp4v2/include -I../mp4v2 -I../faad2/libfaad -I../faad2/include -I../mp3gain  -I/opt/local/include  -pipe -Os -DHAS_LRINTF -arch x86_64 -MT syntax.o -MD -MP -MF .deps/syntax.Tpo -c -o syntax.o syntax.c
:info:build /usr/bin/clang++ -DHAVE_CONFIG_H  -I../mp4v2/include -I../mp4v2 -I../faad2/libfaad -I../faad2/include -I../mp3gain  -I/opt/local/include  -pipe -Os -stdlib=libc++ -arch x86_64 -MT MP4MetaFile.o -MD -MP -MF .deps/MP4MetaFile.Tpo -c -o MP4MetaFile.o MP4MetaFile.cpp
:info:build make[1]: *** No rule to make target `../faad2/libfaad/libfaad.la', needed by `aacgain'.  Stop.
:info:build make[1]: *** Waiting for unfinished jobs....
:info:build In file included from decoder.c:In file included from 39syntax.c:43:
:info:build :
:info:build ../faad2/libfaad/common.h../faad2/libfaad/common.h:39:12: fatal error: '../config.h' file not found
:info:build :39:12: fatal error: '../config.h' file not found
:info:build #  include "../config.h"#  include "../config.h"
:info:build            ^~~~~~~~~~~~~
:info:build            ^~~~~~~~~~~~~
:info:build In file included from MP4MetaFile.cpp:20:
:info:build In file included from ./MP4MetaFile.h:26:
:info:build In file included from ../mp4v2/src/impl.h:6:
:info:build In file included from ../mp4v2/src/src.h:6:
:info:build In file included from ../mp4v2/libplatform/platform.h:24:
:info:build ../mp4v2/libplatform/platform_posix.h:6:10: fatal error: 'libplatform/config.h' file not found
:info:build #include "libplatform/config.h"
:info:build          ^~~~~~~~~~~~~~~~~~~~~~
:info:build 1 error generated.
:info:build 1 error generated.
:info:build make[1]: *** [decoder.o] Error 1
:info:build make[1]: *** [syntax.o] Error 1
:info:build In file included from aacgain.cpp:43:
:info:build In file included from ./MP4MetaFile.h:26:
:info:build In file included from ../mp4v2/src/impl.h:6:
:info:build In file included from ../mp4v2/src/src.h:6:
:info:build In file included from ../mp4v2/libplatform/platform.h:24:
:info:build ../mp4v2/libplatform/platform_posix.h:6:10: fatal error: 'libplatform/config.h' file not found
:info:build #include "libplatform/config.h"
:info:build          ^~~~~~~~~~~~~~~~~~~~~~
:info:build 1 error generated.
:info:build make[1]: *** [MP4MetaFile.o] Error 1
:info:build 1 error generated.
:info:build make[1]: *** [aacgain.o] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9/aacgain'
:info:build make: *** [all-recursive] Error 1
:info:build make: Leaving directory `/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9'
:info:build Command failed:  cd "/opt/local/var/macports/build/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/work/aacgain-1.9" && /usr/bin/make -j4 -w all 
:info:build Exit code: 2
:error:build Failed to build aacgain: command execution failed
:debug:build Error code: CHILDSTATUS 90219 2
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "system {*}$notty {*}$nice $fullcmdstring"
:debug:build     invoked from within
:debug:build "command_exec build"
:debug:build     (procedure "portbuild::build_main" line 8)
:debug:build     invoked from within
:debug:build "$procedure $targetname"
:error:build See /opt/local/var/macports/logs/_Users_jacksonisaac_Development_macports-ports_audio_aacgain/aacgain/main.log for details.

[RichieB2B (Richie B2B)]

You will need to run "configure" and "make" inside the faad2 and mp4v2 subdirs before building aacgain itself. Doing so I ran into this:

/bin/sh ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H   -I./include -I./include -I. -I.  -Wall -Wformat -g -O2 -fvisibility=hidden -c -o src/bmff/typebmff.lo src/bmff/typebmff.cpp
mkdir src/bmff/.libs
 g++ -DHAVE_CONFIG_H -I./include -I./include -I. -I. -Wall -Wformat -g -O2 -fvisibility=hidden -c src/bmff/typebmff.cpp  -fno-common -DPIC -o src/bmff/.libs/typebmff.o
src/bmff/typebmff.cpp:38:49: error: cannot define or redeclare 'data' here because namespace 'bmff' does not enclose namespace 'Enum<mp4v2::impl::bmff::LanguageCode,
      mp4v2::impl::bmff::LanguageCode::ILC_UNDEFINED>'
const EnumLanguageCode::Entry EnumLanguageCode::data[] = {
                              ~~~~~~~~~~~~~~~~~~^
1 error generated.
make: *** [src/bmff/typebmff.lo] Error 1

This can be fixed by adding these lines to mp4v2/src/src.h

#define _MSC_VER 2000
#define strnicmp(x,y,z) strncasecmp(x,y,z)

After this aacgain is build just fine.