Opened 14 years ago
Closed 14 years ago
#26041 closed defect (fixed)
spidermonkey 1.7.0 +fileobject does not actually enable the file object
Reported by: | onne@… | Owned by: | akitada@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.1 |
Keywords: | Cc: | vjt@… | |
Port: | spidermonkey |
Description
somehow due to the config/Darwin.mk the JS_HAS_FILEOBJECT=1 fails to be passed on during compile as -DJS_HAS_FILEOBJECT
manually configuring, changing config/Darwin.mk and then installing it works out
a quick way to see if it has build correctly:
strings which js
| grep js_NewFileObjectFromFILEecho "no fileobject"
Change History (5)
comment:1 Changed 14 years ago by nerdling (Jeremy Lavergne)
Owner: | changed from macports-tickets@… to akitada@… |
---|---|
Port: | spidermonkey added |
comment:2 Changed 14 years ago by vjt@…
comment:4 Changed 14 years ago by kwatch@…
How about progress? I confirmed that the above patch works well (thanks vjt!).
I hope Macports to include the patch.
comment:5 Changed 14 years ago by pixilla (Bradley Giesbrecht)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed in r76712.
Note: See
TracTickets for help on using
tickets.
Hello,
the following patch both fixes the reported problem, and enables readline support in the interactive JS shell.
The reason is that the DEFINES= parameter to make is shadowing the
Makefile.ref
generated $(DEFINES) variable. Anyway, if the-DJS_C_STRINGS_ARE_UTF8
is not specified on the command line, it gets added automagically byMakefile.ref
, at least on my machine (Macports 1.9.1, Darwin 10.4.0/x86_64).