Opened 14 years ago

Closed 13 years ago

#26148 closed update (fixed)

gst-plugins-base-0.10.30 Update

Reported by: louis-francis.ratte-boulianne@… Owned by: rmstonecipher@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: gst-plugins-base

Description

Update

Changed liboil dependency for orc, the universal variant can now be enabled

Attachments (2)

patch-gst-plugins-base-Portfile.diff (1.8 KB) - added by louis-francis.ratte-boulianne@… 14 years ago.
Portfile patch
patch-add-qt-dep.diff (609 bytes) - added by dbevans (David B. Evans) 14 years ago.
Additional patch for qt dependency

Download all attachments as: .zip

Change History (14)

comment:1 Changed 14 years ago by louis-francis.ratte-boulianne@…

The patch also includes variants to disable ogg and vorbis elements (if there are not needed)

Changed 14 years ago by louis-francis.ratte-boulianne@…

Portfile patch

comment:2 Changed 14 years ago by jmroot (Joshua Root)

Owner: changed from macports-tickets@… to rmsfisher@…
Version: 1.9.1

Please remember to cc the maintainer.

comment:3 Changed 14 years ago by rmsfisher@…

  1. Ratte-Boulianne,
    The current version of the Portfile, committed in r70816, implements your proposed +no_ogg variant.
    A separate +no_vorbis variant would need to:
    1. Remove libtheora from depends_lib
    2. Add libogg to depends_lib
    3. Add --disable-theora and --disable-vorbis to configure.args-append

Similar behaviors would be required for a +no_theora variant.
Please let me know if such additional variants are necessary or if the current +no_ogg variant will suffice.

Cheers,
Ryan

comment:4 Changed 14 years ago by dbevans (David B. Evans)

Still failed to build universal for me as follows:

:info:build /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I../../..   -I/opt/local/include -I../../../gst-libs -I../../../gst-libs -D_REENTRANT -I/opt/local/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2   -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -D_REENTRANT -I/opt/local/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2    -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -Wall -Wmissing-declarations -Wredundant-decls -Wundef -Wwrite-strings -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Waggregate-return -Wno-multichar   -g     -DQT_SHARED -I/opt/local/libexec/qt4-mac/include -I/opt/local/libexec/qt4-mac/include/QtGui -I/opt/local/libexec/qt4-mac/include/QtCore   -pipe -O2 -arch x86_64 -arch i386 -c -o qtgv_xoverla
y-moc_qtgv-xoverlay.o `test -f 'moc_qtgv-xoverlay.cpp' || echo './'`moc_qtgv-xoverlay.cpp
:info:build cc1plus: warning: command line option "-Wmissing-declarations" is valid for C/ObjC but not for C++
:info:build cc1plus: warning: command line option "-Wmissing-declarations" is valid for C/ObjC but not for C++
:info:build ld: warning: in /opt/local/libexec/qt4-mac/lib/QtGui.framework/QtGui, file was built for unsupported file format which is not the architecture being linked (i386)
:info:build ld: warning: in /opt/local/libexec/qt4-mac/lib/QtCore.framework/QtCore, file was built for unsupported file format which is not the architecture being linked (i386)
:info:build Undefined symbols for architecture i386:
:info:build   "QString::free(QString::Data*)", referenced from:
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build   "QObject::connect(QObject const*, char const*, QObject const*, char const*, Qt::ConnectionType)", referenced from:
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build   "QWidget::setWindowTitle(QString const&)", referenced from:
:info:build       _main in qt_xoverlay-qt-xoverlay.o:info:build   "QApplication::activeWindow()", referenced from:
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build   "QWidget::QWidget(QWidget*, QFlags<Qt::WindowType>)", referenced from:
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build   "qFlagLocation(char const*)", referenced from:
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build       _main in qt_xoverlay-qt-xoverlay.o
:info:build   "QWidget::resize(QSize const&)", referenced from:
:info:build       _main in qt_xoverlay-qt-xoverlay.o

There is a missing dependency on qt4-mac which existed on my system but was not built universal. Adding the dependency causes qt4-mac to be rebuilt universal which solves the problem.

qt4-x11 is not a possibility as it is not universal.

Trivial patch attached.

Changed 14 years ago by dbevans (David B. Evans)

Attachment: patch-add-qt-dep.diff added

Additional patch for qt dependency

comment:6 in reply to:  3 Changed 14 years ago by louis-francis.ratte-boulianne@…

I don't quite understand why removing theora is needed when disabling vorbis ? Theora is a video codec, vorbis is an audio codec and ogg is a container format.

comment:7 Changed 14 years ago by rmsfisher@…

Theora depends upon ogg which in turn depends upon vorbis.
To use a terrible analogy, one cannot take a nap in a rowboat on a lake without first going to a lake and then getting in a boat.
Can theora work even when --disable-ogg and --disable-vorbis configure flags are used (assuming libogg, libvorbis, and libtheora are all present)?

comment:8 Changed 14 years ago by rmsfisher@…

Owner: changed from rmsfisher@… to rmstonecipher@…

comment:9 Changed 14 years ago by rmstonecipher@…

Status: newassigned

comment:10 Changed 14 years ago by rmstonecipher@…

I was about to close this ticket based on subject alone when I noticed the additional changes to be added.
Dave, Louis-Francis, could you please test your patches against the current Portfile (0.10.25r2)?
I should be able to update this port to include your patches this week.

Cheers,
Ryan Stonecipher

comment:11 Changed 14 years ago by nerdling (Jeremy Lavergne)

Ryan,

there also seems to be a missing dependency on pangocairo for the current version in macports.

comment:12 Changed 14 years ago by rmstonecipher@…

Jeremy,
I did not find a "pangocairo" port when doing a 'port search' operation.
Cairo is a library dependency of pango.

Pango is a library dependency of gtk2.

Gtk2 is a dependency of gnome-vfs, which is in this port's depends_lib.

Is "pangocairo" some optional dependency of gst-plugins-base which is enabled by default?
I could attempt to port a new gnome library but would want you or Dave to check my work.

comment:13 Changed 13 years ago by rmstonecipher@…

Resolution: fixed
Status: assignedclosed

Please file individual tickets for any lingering issues in this ticket.
gst-plugins-base is now at version 0.10.35 and the 0.11.x series is right around the corner - this ticket is done.

Note: See TracTickets for help on using tickets.