Opened 14 years ago
Closed 14 years ago
#26156 closed submission (fixed)
showkey
Reported by: | phillipao@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.1 |
Keywords: | Cc: | ||
Port: | showkey |
Description
I made a little port of Eric S Raymond's showkey tool. Tested on Snow Leopard. I thought I saw a message during some stage of installation saying "License: Unknown" or something like that. But I don't see information in the guide about licenses. If there's something I can put in the Portfile to show the license, please let me know. Otherwise it's good to go.
Attachments (2)
Change History (5)
Changed 14 years ago by phillipao@…
Changed 14 years ago by phillipao@…
Attachment: | patch-Makefile.diff added |
---|
Makefile diff for showkey
comment:1 follow-up: 2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to ryandesign@… |
---|---|
Port: | showkey added |
Status: | new → assigned |
Replying to phillipao@…:
I made a little port of Eric S Raymond's showkey tool. Tested on Snow Leopard.
Thank you! I'll check it out.
I thought I saw a message during some stage of installation saying "License: Unknown" or something like that.
You saw that in the output of "port info".
But I don't see information in the guide about licenses.
Correct, this field is new and has not yet been documented in the guide. In the absence of documentation you can look at other existing portfiles to see how it's done.
If there's something I can put in the Portfile to show the license, please let me know. Otherwise it's good to go.
You would add the line "license WhateverTheLicenseIs" to the portfile. Based on the file "showkey.spec" the license appears to be MIT, so I will add "license MIT" to the portfile.
I see you've hardcoded /opt/local in the patchfile. You can't assume the user is using /opt/local as their MacPorts prefix; you must use the variable ${prefix}. I'll fix that.
Since this port has no configure script, you need to handle the details of UsingTheRightCompiler and supporting universal and non-default-build_arch builds. I'll see if I can add that too.
There should be a post-destroot block in the Portfile copying the documentation file in place, since the software's Makefile doesn't already install it. I'll add this.
comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Committed in r71183. Sorry about the delay!
Portfile for showkey