Opened 14 years ago
Closed 14 years ago
#26167 closed defect (wontfix)
qt4-mac: reinplace didn't change anything in phonon.pro
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | michaelld (Michael Dickens) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.1 |
Keywords: | Cc: | ||
Port: | qt4-mac |
Description
Using the MacPorts base patch from #15514 I see this message:
---> Computing dependencies for qt4-mac ---> Fetching qt4-mac ---> Verifying checksum(s) for qt4-mac ---> Extracting qt4-mac ---> Applying patches to qt4-mac Warning: reinplace /PHONON_MINOR_VERSION =/s@\([^0-9]*\)[0-9]*\([^0-9]*\)@\13\2@ didn't change anything in /mp/var/macports/build/_Volumes_data_macports_ports_aqua_qt4-mac/work/qt-everywhere-opensource-src-4.6.3/src/phonon/phonon.pro ---> Configuring qt4-mac ^C
Seems that reinplace might not be correct.
Change History (2)
comment:1 Changed 14 years ago by michaelld (Michael Dickens)
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Understood, thanks.
Note: See
TracTickets for help on using
tickets.
In this case, that's true -- but, the script is working as desired. The original file started with "PHONON_MINOR_VERSION = 3", and the reinplace replaced the '3' with another '3' (the one picked up from the CMakeLists.txt). So, yes, technically I don't need to reinplace the minor number in this case. That said, the script is generic & works with both qt4-mac & qt4-mac-devel, and should for any foreseeable qt4-mac versions. So, unless you're really against keeping this as is, that's what I'm going to do.