Opened 14 years ago

Closed 14 years ago

#26174 closed submission (fixed)

Xymon client

Reported by: fclaire@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc: raimue (Rainer Müller), anddam (Andrea D'Amore)
Port: xymon

Description

Here's a port of xymon client

Thanks for checking it.

Attachments (5)

patch-build-Makefile.rules.diff (313 bytes) - added by fclaire@… 14 years ago.
patch-client-hobbitclient-darwin.sh.diff (580 bytes) - added by fclaire@… 14 years ago.
patch-lib-Makefile.diff (299 bytes) - added by fclaire@… 14 years ago.
Portfile (5.2 KB) - added by fclaire@… 14 years ago.
patch-client-xymonclient-darwin.sh.diff (578 bytes) - added by fclaire@… 14 years ago.

Download all attachments as: .zip

Change History (16)

Changed 14 years ago by fclaire@…

Changed 14 years ago by fclaire@…

Changed 14 years ago by fclaire@…

Attachment: patch-lib-Makefile.diff added

comment:1 Changed 14 years ago by raimue (Rainer Müller)

Keywords: xymon removed

comment:2 Changed 14 years ago by raimue (Rainer Müller)

Some parts of my comment on xymon-server also apply here.

comment:3 Changed 14 years ago by fclaire@…

I've put the adduser part to pre-destroot as recommended.

I hope this change will make xymon client port accepted.

comment:4 Changed 14 years ago by raimue (Rainer Müller)

Cc: raimue@… added

Looking at this again, I noticed another thing:

destroot.env-append     INSTALLROOT=${destroot}

should probably be

destroot.destdir     INSTALLROOT=${destroot}

which would overwrite the original DESTDIR setting (or is DESTDIR still being used?).

Could the symlinks in post-activate be done in post-destroot already? Files created in post-activated will not be uninstalled properly, also re-activation would fail as the file already exists. Use ln -sf to force creation of links to non-existing targets.

The notes section should use ${xymonuser} instad of hardcoding the user name.

Sorry that I didn't bring these up earlier... :-(

comment:5 Changed 14 years ago by fclaire@…

Hi, I'll try to get it fixed soon. Thanks for checking it again.

comment:6 Changed 14 years ago by fclaire@…

I'm finally back.

DESTDIR isn't used in the original source package. I may report this to the xymon mailing list to have it fixed in future releases. I tried destroot.destdir and it didn't worked so I kept destroot.env-append.

For the symlinks, I just found they weren't required in the xymon client package so I just got rid of them and adapted the env variables accordingly.

I updated the notes section to use ${xymonuser}.

Now I cross finger to get it accepted.

comment:7 Changed 14 years ago by anddam (Andrea D'Amore)

Cc: and.damore@… added

Cc Me!

comment:8 Changed 14 years ago by fclaire@…

I've added a conflicts line in the Portfile.

comment:9 Changed 14 years ago by fclaire@…

According to the xymon mailing list, a new beta or release-candidate for v 4.3.0 is going to be released in the coming days.

I would be worth waiting for it before releasing out the xymon ports. I'll update the Portfiles with it once successfully tested on my environment.

Changed 14 years ago by fclaire@…

Attachment: Portfile added

Changed 14 years ago by fclaire@…

comment:10 Changed 14 years ago by fclaire@…

So here we go with the new xymon beta version 4.3.0.beta3.

This is a quite major release as all renaming to move away from "Hobbit" has been implemented. This has an impact on most of the config files as well as some internal variables.

The Portfile has been adapted to those changes and has been improved. A new patch needs to be used: patch-client-xymonclient-darwin.sh.diff

The file patch-client-hobbitclient-darwin.sh.diff is now useless and shouldn't be included in the port files directory.

Thanks for checking it.

comment:11 Changed 14 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: newclosed

Committed r73753

Note: See TracTickets for help on using tickets.