#26179 closed enhancement (fixed)
bzflag: consistent whitespace, please
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | phw@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | bzflag |
Description
The bzflag portfile uses inconsistent indentation. Most of the portfile uses tabs at 8 spaces per tab for indentation lining up at column 20 (meaning there are also spaces thrown in there), but the checksum lines use tabs at 4 spaces per tab lining up at column 20. And the livecheck lines use 8-space tabs lining up at column 24. Please switch to a consistent indentation style using only spaces. Adding the standard MacPorts modeline would also be a good idea at that point. Attached is one possible fix.
Attachments (1)
Change History (3)
Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | bzflag-whitespace.diff added |
|---|
comment:1 Changed 14 years ago by phw@…
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Resolved in revision 77966
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
If instead of "revision 77966" you write "r77966", Trac will make a helpful link out of it.
Note that it is better to make whitespace changes in a separate commit from functional changes; that way, whitespace commits can be ignored by people reviewing commits, and in functional commits, the changes are easy to see.
proposed patch