makeicns cannot compile i386 ppc on Mac OS X 10.4 PowerPC

[200309@…]

Read recently about makeicns and tried to compile but got an error.
What is the problem?

$ sudo port install makeicns
--->  Computing dependencies for makeicns
--->  Fetching makeicns
--->  Attempting to fetch 1.4.tar.bz2 from http://distfiles.macports.org/makeicns
--->  Verifying checksum(s) for makeicns
--->  Extracting makeicns
--->  Configuring makeicns
--->  Building makeicns
Error: Target org.macports.build returned: shell command failed
Log for makeicns is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_makeicns/main.log
Error: Status 1 encountered during processing.

Attached is the "main.log"

[sewebster@…]

Looks like an architecture issue. What kind of CPU do you have? For me, to my uninformed eye, it looks like it tries to compile for ppc and i386. Maybe you only have a ppc, not an intel chip, so it doesn't work.

[sewebster@…]

Cc Me!

[200309@…]

Replying to sewebster@…:

Looks like an architecture issue. What kind of CPU do you have? For me, to my uninformed eye, it looks like it tries to compile for ppc and i386. Maybe you only have a ppc, not an intel chip, so it doesn't work.

Yes, this machine is PPC.

[sewebster@…]

patch to disable i386

[sewebster@…]

You could try the attached patches to see if it works for you, but all I did was cut out the i386 part, so this only works for ppc users.

[jmroot (Joshua Root)]

Please remember to fill in the Port field and cc the maintainers.

[200309@…]

Replying to jmr@…:

Please remember to fill in the Port field and cc the maintainers.

ok... this is my first post. Any other suggestions? -Bill

[200309@…]

Replying to sewebster@…:

You could try the attached patches to see if it works for you, but all I did was cut out the i386 part, so this only works for ppc users.

Where do I find info about how to apply the patches?

-Bill

[200309@…]

Cc Me!

[sewebster@…]

Probably the easiest thing to do is to download the patch-Makefile.diff file (download link at the bottom of the diff page), then (from the directory you downloaded the patch)

sudo mkdir `port dir makeicns`/files
sudo cp patch-Makefile.diff `port dir makeicns`/files

then sudo port edit makeicns and manually make the change that you can see I made in the Portfile diff (add the patchfiles line to the bottom). Then sudo port install makeicns again and see what happens.

[200309@…]

Replying to sewebster@…:

Probably the easiest thing to do is to download the patch-Makefile.diff file (download link at the bottom of the diff page), then (from the directory you downloaded the patch)

sudo mkdir `port dir makeicns`/files
sudo cp patch-Makefile.diff `port dir makeicns`/files

then sudo port edit makeicns and manually make the change that you can see I made in the Portfile diff (add the patchfiles line to the bottom). Then sudo port install makeicns again and see what happens.

Thank you. That worked.

Soon, I will find out how and what makeicns can do.

-Bill

[sewebster@…]

new makefile patch 1

[sewebster@…]

new makefile patch 2

[sewebster@…]

patch to Portfile using platform specific Makefile patches

[sewebster@…]

I uploaded a new Portfile patch and two Makefile patches. The modified Portfile applies the appropriate Makefile patch based on the platform the user is running. Could be a better way to do this. Also, no 64 bit I guess.

[ryandesign (Ryan Carsten Schmidt)]

Replying to sewebster@…:

Maybe you only have a ppc, not an intel chip, so it doesn't work.

It doesn't work because the user is on Mac OS X 10.4 PowerPC, which contains only the ppc architecture; every other Mac OS X version MacPorts supports contains at least ppc and i386 architectures. If you want to compile ppc and i386 on 10.4 PowerPC you must use the MacOSX10.4u.sdk. As far as I remember, the path to the this SDK will be in the variable ${configure.universal_sysroot} for you to use if it is needed (i.e. on 10.4 PowerPC only); on all other OS the variable is empty.

The port does not have a universal variant. The software should not build universal unless the port has a universal variant and the user has selected it.

The port should build for the architecture(s) the user requested. That means examining ${configure.build_arch} or ${configure.universal_archs} depending on whether building universal or not.

If 64-bit is not supported, the port should so indicate using "supported_archs i386 ppc" and, if enabling universal builds, by setting "configure.universal_archs i386 ppc" as well.

[sewebster@…]

It appears that this port is really a fairly minimal program... and currently doesn't even have a configure phase. I'm guessing the maintainer just set it up quickly and the result is that it doesn't work on 10.4.

[mkae (Marko Käning)]

Here is the "maintainer". :)

I admit it was a quick setup. I don't have opportunity to test this with <10.6, actually. So, I welcome all proposals to make the portfile better, also for older versions. :)

I could patch in the latest submitted patchfiles into the current portfile if that's the way to go.

Am ready to learn how to improve this portfile.

[mkae (Marko Käning)]

Here is what Brad (co-maintainer of this port) suggested:

With these vars it's easier to change the build without committing changes to Makefile.

I think it's perfectly acceptable to require env vars for make. That's how postfix does it. Now ./configure.

(I'll attach the corresponding patch files in a minute.)

What do you guys think about this hack?

[mkae (Marko Käning)]

Brad's suggestion

[mkae (Marko Käning)]

Brad's suggestion

[mkae (Marko Käning)]

Replying to MK-MacPorts@…:

With these vars it's easier to change the build without committing changes to Makefile.

I think it's perfectly acceptable to require env vars for make. That's how postfix does it. Now ./configure.

The last bit should be "NO ./configure", actually!

[200309@…]

The patches sent to me by Scott Webster sewebster@gmail.com
allowed makeicns to compile on 10.4.11 PPC
--AND--
I can now make beautiful icons.
Thank you.

[200309@…]

I tried to compile makeicns on a MacOSX 10.5.8 PPC
It compiled without any problem.
Then tried on another MacOSX 10.4.11 PPC and it failed as per my original post.
-Bill

[sewebster@…]

I think that "Brad's suggestion" is getting closer to the ideal, probably as described by Ryan... but it still builds universal when not requested and I don't think it will work on 10.4?

[ryandesign (Ryan Carsten Schmidt)]

I am working on a patch now.

[ryandesign (Ryan Carsten Schmidt)]

proposed patch

[ryandesign (Ryan Carsten Schmidt)]

Attached​.

[ryandesign (Ryan Carsten Schmidt)]

Replying to sewebster@…:

I think that "Brad's suggestion" is getting closer to the ideal

"Brad's suggestion" appears to be based on the old 1.2 version of the port; we're up to 1.4 now... Try my patch instead.

[pixilla (Bradley Giesbrecht)]

Adds "make all" target to Makefile and drops build.target from Portfile

[mkae (Marko Käning)]

Hi folks, I just committed the suggested changes (patch for Makefile as well as the updated Portfile) as rev 70885. Hope this solves current issues eventually.

[200309@…]

Replying to MK-MacPorts@…:

Hi folks, I just committed the suggested changes (patch for Makefile as well as the updated Portfile) as rev 70885. Hope this solves current issues eventually.

PowerBook G3 Pismo 500MHz PPC 10.4.11 compile ok

iBook G4 1.42GHz PPC 10.5.8 compile ok

I do not have an Intel to test.

Thank you, Bill

[jmroot (Joshua Root)]

Why are you restricting the port to only build for i386 and/or ppc?

[sewebster@…]

Compiles and works fine x86_64 for me (I just added x86_64 to the supported_archs line).

[mkae (Marko Käning)]

Hi, the restriction was non-intentional. Thanks to sewebster it could be proven that it works fine for 64bit, although there were doubts coming up during this discussion. (Fixed in rev. 70890.)

Thanks for all the help!

There is the thought now to completely get rid of the Makefile patch file and change makeicns' Makefile in its sources, which is probably the best idea.

[mkae (Marko Käning)]

Actually I don't know whether it makes sense to build the program by default as universal with ppc and i386... Who actually needs that? Wouldn't it make more sense to take x86_64 and i386 nowadays? Does one need a universal variant at all?

[jmroot (Joshua Root)]

There doesn't appear to be any reason you couldn't just remove the supported_archs and configure.universal_archs lines altogether.

[mkae (Marko Käning)]

So, why not do it then? Thanks jmr, I'll test it and commit the change.

[mkae (Marko Käning)]

I think this would do the trick concerning omitting the universal variant after all. Can someone please test whether it also works on other platforms as it does for me on 64bit?!

[sewebster@…]

If it is considered "good macports practice" to have a universal variant when possible, then you might want to leave it in...

[mkae (Marko Käning)]

Replying to sewebster@…:

If it is considered "good macports practice" to have a universal variant when possible, then you might want to leave it in...

OK, so, how can I make the universal variant non-default? What would have to be changed in the current Portfile to achieve that the universal variant has to selected by the user, otherwise the system default would be used. Or is this also "not good" practice?

[mkae (Marko Käning)]

Well, and which archs should be selected for the universal variant? PPC and i386? Which recommendations exist? Probably you can point me to some place in the MacPorts manual...

[sewebster@…]

You just need to remove the supported_archs and configure.universal_archs lines as suggested above (from revision 2). Then it will use the default supported arches and universal arches. Leave the universal variant in, it won't be selected by default, but will work if users request it. The arches they build it for will depend on their preferences. This is the variants part of the guide, not sure how helpful it is to you: ​http://guide.macports.org/#development.variants

[mkae (Marko Käning)]

Thanks sewebster. :)

I'll do as you say and commit it finally.

[mkae (Marko Käning)]

Latest version in rev 70902.

[sewebster@…]

The new version (rev 4) works for me both as x86_64 and universal (x86_64 and i386). It's nice if you can just write the revision numbers with an r in front, like this r70902 because then the wiki makes a link automatically.

[mkae (Marko Käning)]

Thanks for keeping me posted! Concerning the revision numbering: will do next time. Thanks for the hint! Hope to get also feedback from Brad during the next hours. Would be great if 200309@… could also test it on the PPC systems...

[mkae (Marko Käning)]

Portfile update for makeicns version 1.5 not needing any patches anymore. Ryan could you please test the universal variant as well as on TIGER?! Thanks

[mkae (Marko Käning)]

I am wondering whether makeicns' latest update in r75880 might have solved this issue...

[ryandesign (Ryan Carsten Schmidt)]

Nope; see ​https://bitbucket.org/mkae/makeicns/issue/6/invalid-arch-name-powerpc

[mkae (Marko Käning)]

Hopefully fixed with r75885.

[200309@…]

Replying to mk@…:

Hopefully fixed with r75885.

MacOSX 10.4.11 PowerBook G3 Pismo 500MHz

Thank you... makeicns now compiles! -Bill

20110211.222751
Portfile changed since last build; discarding previous state.
--->  Fetching makeicns
--->  Attempting to fetch makeicns-1.4.2.tar.bz2 from http://distfiles.macports.org/makeicns
--->  Verifying checksum(s) for makeicns
--->  Extracting makeicns
--->  Configuring makeicns
--->  Building makeicns
--->  Staging makeicns into destroot
--->  Installing makeicns @1.4.2_0
--->  Deactivating makeicns @1.4_5
--->  Cleaning makeicns
--->  Activating makeicns @1.4.2_0
--->  Cleaning makeicns
--->  Uninstalling makeicns @1.4_5
--->  Cleaning makeicns

[mkae (Marko Käning)]

Great. So I'll close this ticket then. Thanks again to Ryan who's patch brought the breakthrough! :-)