#26440 closed enhancement (fixed)
nodejs: Add +no_ssl variant
Reported by: | tonym@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.1 |
Keywords: | haspatch | Cc: | ceager@… |
Port: | nodejs |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
Attached are two patches to enhance nodejs with a +no_ssl variant so it can be built without SSL support, alleviating the gnutls/openssl dependencies.
PATCHES
- Portfile.diff -- Add +no_ssl variant to nodejs
- patch-wscript.diff -- Fix broken configure target. this patch has also been submitted to node.js and is pending integration into a later release.
Attachments (3)
Change History (8)
Changed 14 years ago by tonym@…
Attachment: | patch-Portfile.diff added |
---|
Changed 14 years ago by tonym@…
Attachment: | patch-wscript.diff added |
---|
patch to wscript to fix bug in ./configure --without-ssl
. See Portfile for reference.
comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Description: | modified (diff) |
---|---|
Keywords: | haspatch added; patch removed |
Summary: | Add +no_ssl variant to nodejs → nodejs: Add +no_ssl variant |
comment:2 Changed 14 years ago by tonym@…
0001-update-to-0.2.2.patch obsoletes the prior 2 patches, patch-Portfile.diff and patch-wscript.diff. It updates nodejs to 0.2.2
comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to ryandesign@… |
---|---|
Status: | new → assigned |
comment:4 follow-up: 5 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
We're trying to move away from "no_" variants, now that MacPorts supports remembering negative variants (with the SQL registry, anyway), so I made it an "ssl" variant in r71711 along with updating to 0.2.2 (see also #26551). I removed the gnutls dependency, leaving only the openssl dependency, because gnutls support appears to have vanished from the source code between versions 0.1.92 and 0.1.104.
comment:5 Changed 14 years ago by tonym@…
Replying to ryandesign@…:
I made it an "ssl" variant in r71711 along with updating to 0.2.2 (see also #26551).
looks good
I removed the gnutls dependency, leaving only the openssl dependency,
Smart thinking
nodejs-0.2.2 installed as expected.
$ port -v MacPorts 1.9.1 $ sudo port install nodejs -ssl ---> Activating nodejs @0.2.2_0 $ gcc -v gcc version 4.2.1 (Apple Inc. build 5664) $ uname -v Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 $ node -v v0.2.2
Thanks for merging that in and correcting those flaws. Cheers.
patch to Portfile adding +no_ssl variant