mlt: update to upstream version 0.5.10

[ryandesign (Ryan Carsten Schmidt)]

The revision line should be dropped when increasing the revision.

What's with the mmx variant? The description says "OK for x86_64". Does this mean it's not ok for i386, ppc and ppc64? If so, the portfile should ensure the variant cannot be selected when build_arch is something on which it won't work. Or is it a good idea to just always enable MMX when it's available?

[ddennedy (Dan Dennedy)]

Re: the revision line. OK, overlooked.

Re: mmx variant The mmx and sse asm automatically disables on ppc. I got tickets for build failures on x86 for OS X but not Linux. I am not in a position to address this at the code level. Adding --disable-mmx made the problem go away, but that asm builds fine on x86-64, so I want an opt-in. I will look into how to enforce the variant rule using build_arch as you suggested. Better yet, I would like to only add the --disable-mmx configure option on not build_arch = x86_64. I will look into how to do that as well.

[ddennedy (Dan Dennedy)]

I updated the portfile. The original ticket where the problem was reported is #24698.

[ryandesign (Ryan Carsten Schmidt)]

So just to confirm, the way you have it written now, MMX will be disabled on Snow Leopard when building for i386, but will be enabled on Snow Leopard when building for x86_64 and will be enabled on Leopard and Tiger for both i386 and x86_64. Is that how you want it?

[ddennedy (Dan Dennedy)]

Ryan, yes, that is what I intended. Previous to Snow Leopard, --disable-mmx was not needed AFAIK. I referenced the ffmpeg Portfile and noticed their rule similar to my new one. I traced it to this ticket and comment as the reason: ​https://trac.macports.org/ticket/20938#comment:22 Make sense to you? MLT is using PIC.

[ryandesign (Ryan Carsten Schmidt)]

Replying to dan@…:

Previous to Snow Leopard, --disable-mmx was not needed AFAIK.

I just worry because --disable-mmx was originally added for Tiger only in #21925, but there was no explanation in the ticket for why.

[ddennedy (Dan Dennedy)]

good catch. I appreciate your thoroughness. Uploading new patch that only enables mmx on x86_64 Snow Leopard, which is all I can support and knows that works.

[ddennedy (Dan Dennedy)]

update to 0.5.10, permit ffmpeg or ffmpeg-devel, and enable mmx only on x86_64 Snow Leopard

[ryandesign (Ryan Carsten Schmidt)]

What was the reason, by the way, that we're downloading from git instead of from the ​available distfiles?

[ryandesign (Ryan Carsten Schmidt)]

The reason is probably that when mlt was first added in r52065 it was for a development version of 0.4.0. As soon as we updated to the final version of 0.4.2 in r53221 we probably should have switched to using distfiles as usual. I suggest we take this opportunity to do this now. How does the attached patch look to you? It builds ok for me.

[ryandesign (Ryan Carsten Schmidt)]

proposed patch

[ddennedy (Dan Dennedy)]

It is a good idea. I thought about it too when I learned about livecheck. The only problem I have with the the patch is rmd160. I am not familiar with it. I installed hashalot on my Ubuntu box, and I could not figure out how to generate the equivalent of what you have:

$ rmd160 -x < releases/mlt-0.5.10.tar.gz

Probably using it wrong, but in order to maintain the Portfile I need to know, and Google is not helping me.

[ryandesign (Ryan Carsten Schmidt)]

Committed in r71720.

When you want to update the port, update the version field, then run "sudo port -d checksum"; the checksums won't match, so MacPorts will print new checksums for you.

[ryandesign (Ryan Carsten Schmidt)]

Or you can generate checksums manually with openssl, e.g. using

openssl dgst -sha1 releases/mlt-0.5.10.tar.gz
openssl dgst -rmd160 releases/mlt-0.5.10.tar.gz

[ddennedy (Dan Dennedy)]

ok, I reproduced your rmd160 using openssl.