Opened 14 years ago
Closed 14 years ago
#26513 closed enhancement (fixed)
openldap @2.4.21_1 additional variants
| Reported by: | tehfink | Owned by: | landonf (Landon Fuller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | openldap |
Description
i added additional variants for the overlay '—configure' options.
for example: '--enable-memberof' = '+memberof_overlay'
i hope everything is correct; it's my first time!
Attachments (2)
Change History (6)
Changed 14 years ago by tehfink
| Attachment: | Portfile-rrdtool.diff added |
|---|
comment:1 Changed 14 years ago by mf2k (Frank Schima)
| Cc: | djsnickles@… removed |
|---|---|
| Keywords: | haspatch added; overlay memberof removed |
| Owner: | changed from macports-tickets@… to landonf@… |
| Version: | 1.9.1 |
comment:2 Changed 14 years ago by tehfink
to be honest, i think all the overlays should be included as default, as they are very useful and 'memberOf' is relatively common. including all overlays is simply '--enable-overlays' in the configure script: the variant '+all_overlays'. should i upload a new patch with just the variant '+overlays'?
i included all the overlays separately to emulate freebsd's 'make config' for this same port, which lists each overlay and then some.
Changed 14 years ago by tehfink
| Attachment: | Portfile-openldap.diff added |
|---|
comment:3 Changed 14 years ago by tehfink
New diff includes just one variant: "overlays" which translates to the configure script's "--enable-overlays" Just tested with the latest openldap (2.4.21_2)
comment:4 Changed 14 years ago by takanori@…
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
His latest patch ('Portfile-openldap.diff') seems to be ok for me.
Committed in r74155 as per request from djsnickles. Thanks.
This seems like too many variants to me. What is the argument against just adding all of those configure options into the normal port? Alternately maybe can these be combined into a single "overlays" variant with all of the overlays enabled?