Opened 14 years ago

Closed 13 years ago

#26516 closed update (fixed)

synergy: update to 1.3.7 for Lion compatibility

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: ascarter@…
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: lion Cc: drkp (Dan Ports), cad@…, g5pw (Aljaž Srebrnič), jdswinbank (John Swinbank), neoroman@…, mni@…, raimue (Rainer Müller), ak.ml@…, gardnermj@…
Port: synergy

Description

Here is a patch which updates synergy in these ways:

  • update version to 1.3.5-rc
  • use cmake build system (new for version 1.3.5-rc)
  • project hosting has moved from sourceforge to googlecode
  • fix livecheck
  • fetch and copy config.h.in which was left out of the 1.3.5-rc distfile
  • remove server variant and just always install the launchd plist; if the user doesn't want this they should set "startupitem_type none" in macports.conf
  • remove configure script patch, since there is no longer a configure script, and the patch just removed the "-Werror" flag, but 1.3.5-rc builds fine without such a patch
  • removed "--sysconfdir=${prefix}/etc/${name}" because I could not find a cmake equivalent

I have tested this builds on Snow Leopard, but have not tested the software works. Somebody should test if this version works, and in particular, if it can find its settings file in ${prefix}/etc/${name}; if so, I can commit it.

We usually don't update ports to non-release versions. But 1.3.5-rc has been out since April. The prior version, 1.3.4, doesn't build at all for me, and the version in the port, 1.3.1, is over four years old by now.

Attachments (2)

synergy-1.3.5-rc.diff (2.9 KB) - added by ryandesign (Ryan Carsten Schmidt) 14 years ago.
proposed patch
synergy-1.3.7.diff (9.1 KB) - added by drkp (Dan Ports) 13 years ago.

Download all attachments as: .zip

Change History (13)

Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: synergy-1.3.5-rc.diff added

proposed patch

comment:1 Changed 14 years ago by drkp (Dan Ports)

Cc: dports@… added

Cc Me!

comment:2 Changed 14 years ago by drkp (Dan Ports)

I gave this patch a try today but quickly reverted back to the existing 1.3.1 because modifier keys were not working when using my Mac as a client. It looks like this is http://synergy-foss.org/pm/issues/2743 which has not yet been fixed.

I didn't try the server (or startupitem, config file, etc) at all.

comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: cad@… added

Duplicate #28267 points out 1.3.6 is now available. The upstream bug referenced above is not closed yet, but there are many new comments in it.

comment:4 Changed 13 years ago by drkp (Dan Ports)

Cc: a2piratesoft@… swinbank@… neoroman@… mni@… added
Keywords: lion added
Summary: synergy: update to 1.3.5-rcsynergy: update to 1.3.7 for Lion compatibility

synergy fails to build on Lion (#30325) because 1.3.1 uses long-deprecated APIs that have been removed. Updating the port to the latest version (now 1.3.7) appears to resolve this.

Here is an updated version of Ryan's patch to update to 1.3.7.

re: the modifier key issue, I tried the client and things seemed to work OK. I did notice that the mapping between meta/super and cmd/option was swapped somewhere in the interim, which took me by surprise (but can be changed in the config file).

I have only tested the client, not the server. If someone who uses the server regularly wants to give it a try, that would be much appreciated.

Changed 13 years ago by drkp (Dan Ports)

Attachment: synergy-1.3.7.diff added

comment:5 Changed 13 years ago by drkp (Dan Ports)

I tried the server today, and it didn't work very well because of this bug: http://synergy-foss.org/pm/issues/57

It looks like it's fixed (or partially fixed?) in synergy trunk, or maybe the latest beta release, but the fix is not in 1.3.7, so I backported the patches. Updated diff attached.

comment:6 Changed 13 years ago by raimue (Rainer Müller)

Cc: raimue@… added

I worked on this on my own until I discovered this ticket and made some major changes to the Portfile. I have now also applied the patches Dan provided above (thanks!). In addition to that I also fixed the startupitem as this use of killall freaked me out.

This work is in my ports tree. You can also view a diff against of the current version in trunk/dports and mine.

comment:7 Changed 13 years ago by drkp (Dan Ports)

Looks good to me. (And if you're going to maintain it, even better!)

I'd been wondering about the startup item. Using --daemon, forking, and killall seemed redundant; thanks for fixing that. Actually, I was a bit surprised to see it as a LaunchDaemon, since I'm used to launching synergys from a user session instead of as root. That would argue for making a LaunchAgent instead (which we don't have convenient support for). But I'm guessing this is another approach that would let you use synergy at the login screen too?

Oh, and don't forget the license. I believe it's GPL-2.

comment:8 Changed 13 years ago by ak.ml@…

Cc: ak.ml@… added

Cc Me!

comment:9 Changed 13 years ago by drkp (Dan Ports)

This patch looks good to me (and I've been using it for some time now); any reason you haven't committed it yet?

comment:10 Changed 13 years ago by gardnermj@…

Cc: gardnermj@… added

Cc Me!

comment:11 Changed 13 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Marked as nomaintainer in r87685 for inactivity of the listed maintainer.

Update to 1.3.8 committed in r87686.

Note: See TracTickets for help on using tickets.