Opened 14 years ago
Closed 13 years ago
#26524 closed update (fixed)
clamav-server: update to 0.96.2
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | pixilla (Bradley Giesbrecht) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.1 |
Keywords: | Cc: | danielluke (Daniel J. Luke) | |
Port: | clamav-server, clamav |
Description
Should clamav-server be updated to 0.96.2? livecheck says that version is available, and that's what version the clamav port is already at.
Attachments (1)
Change History (11)
comment:1 follow-up: 2 Changed 14 years ago by pixilla (Bradley Giesbrecht)
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | dluke@… added |
---|---|
Port: | clamav added |
Replying to brad@…:
Well, I guess livecheck is bogus unless it is to be used to verify that the plists installed will still work with new versions of clamav. The clamav-server port installs plist files and sets up system users, run and log dirs.
Should we keep the version in sync with clamav
That's what I do with mysql5-server; I update its version in sync with mysql5's.
or make livecheck always current?
I think it would be nice if this port were incorporated into dlukes' clamav port.
Perhaps. But if so, then similar thoughts would apply to mysql5-server, postgresql90-server, etc. Before these -server ports existed, their functionality was in +server variants in their parent ports. The problem with this was the time needed to rebuild the parent port when the user forgot to use the +server variant. So if we bring the server plists and user and group and directory creation back into the parent port, it must be on by default, only bracketed to be disabled if ${startupitem.type} is "none". I have been meaning to do that actually but hadn't gotten around to testing whether it would work, but I think it will.
comment:3 Changed 14 years ago by pixilla (Bradley Giesbrecht)
I don't see the harm in installing the plists by default as the user must set them up and turn them on. Same goes for setting up dirs and users. It's not a big resource waste.
But the current approach works well too.
Changed 14 years ago by pixilla (Bradley Giesbrecht)
Attachment: | patch-Portfile.diff added |
---|
sync version with port clamav @0.96.2
comment:4 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Right, I'm not concerned at all about that, what I'm concerned about is that if you unconditionally go creating users and groups and creating directories owned by those users and groups, without first checking that the user requested server functionality by checking that ${startupitem.type} is not "none", then users who are e.g. not running as root will be unable to install the port at all. That's the situation I want to prevent.
comment:5 Changed 14 years ago by pixilla (Bradley Giesbrecht)
sudo port uninstall clamav-server sudo port uninstall clamav port install clamav Error: Insufficient privileges to write to MacPorts install prefix.
I don't seem to be able to install much of anything as non-root. Is this due to the way I originally installed MacPorts?
$ ls -d1 -la /opt drwxrwxr-x 4 root admin 136 Aug 17 12:03 /opt
comment:6 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Yes. I'm talking about those users who install MacPorts as an unprivileged user?.
comment:7 Changed 14 years ago by pixilla (Bradley Giesbrecht)
So the problem is writing to /Library/LaunchDaemons.
Then let's keep it as is and update the version.
I submitted a version bump patch earlier. patch-Portfile.diff
Thanks Ryan.
comment:8 Changed 14 years ago by jmroot (Joshua Root)
Writing to /Library/LaunchDaemons hasn't been a problem for a while now. source:tags/release_1_9_1/base/src/port1.0/portstartupitem.tcl#L591
comment:9 Changed 14 years ago by danielluke (Daniel J. Luke)
The idea with separate ports is that if something requires clamav running as a server, it can depend on the clamav-server port (just like with the postgres ports)
comment:10 Changed 13 years ago by jmroot (Joshua Root)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version bump happened in r75684.
Well, I guess livecheck is bogus unless it is to be used to verify that the plists installed will still work with new versions of clamav. The clamav-server port installs plist files and sets up system users, run and log dirs.
Should we keep the version in sync with clamav or make livecheck always current?
I think it would be nice if this port were incorporated into dlukes' clamav port.