kdenetwork4 +libmsn fails to build due to outdated libmsn

[macports@…]

libmsn needs to be updated to current version for kdenetwork4 +libmsn to build. The +libmsn variant enabled compilation of the WLM plugin for Kopete. I see no reason for this variant to be off by default as long as the libmsn port is maintained. All other protocols supported my Kopete are compiled by default.

I have modified the Portfile for libmsn to bring in current version (4.1) instead of the ancient version currently used (3.2). I have also added use of a patch that is in libmsn svn, but not yet included in a release, for compatibility with OpenSSL 1.0.0 since MacPorts is now using that version. With these changes, kdenetwork4 +libmsn builds clean and Kopete shows WLM as a usable protocol.

Please use the supplied files to update the libmsn port so that others may benefit from my efforts.

[macports@…]

Updated Portfile

[macports@…]

Patch for OpenSSL 1.0.0 compatibility

[ryandesign (Ryan Carsten Schmidt)]

Thanks for the suggestion. In r71681 I updated libmsn to 4.1, making only the minimal changes to get this working, including updating the homepage, version, checksums, adding your patchfile, and using the cmake portgroup (instead of manually specifying a cmake build). In r71682 I made whitespace changes.

Now we need to turn our attention to the kdenetwork4 port. Its libmsn and xmms variant do nothing but add a dependency, which is a pretty good indication that these variants are incomplete and should either be completed (ensuring the port does not use the dependency even if it is already installed unless the variant is selected) or removed (and the dependency added always).

[macports@…]

Replying to ryandesign@…:

Thanks for the suggestion. In r71681 I updated libmsn to 4.1, making only the minimal changes to get this working, including updating the homepage, version, checksums, adding your patchfile, and using the cmake portgroup (instead of manually specifying a cmake build). In r71682 I made whitespace changes.

Now we need to turn our attention to the kdenetwork4 port. Its libmsn and xmms variant do nothing but add a dependency, which is a pretty good indication that these variants are incomplete and should either be completed (ensuring the port does not use the dependency even if it is already installed unless the variant is selected) or removed (and the dependency added always).

Use of the cmake portgroup is cleaner that what I had done. Thanks for show me a useful trick. I am not a portfile expert, I just used the file for another port that builds with cmake as a template to update libmsn. Mostly just hacking away to get working what I want.

I took a look at the kdenetwork4 portfile after reading your post. I think it best to just add the libmsn depend in there by default, and of course add it to the depends_lib-delete group for the no_kopete variant. This would follow what was done with meanwhile, which is another protocol supported by Kopete through an external library. The no_kopete variant should probably also have port:meanwhile added to its depends_lib-delete group so that library is not built needlessly if Kopete is left out.

As far as xmms, I think that should stay a variant for two reasons. Firstly, it is only used for an extraneous plugin, not core functionality like an entire IM protocol. Secondly, XMMS is huge compared to libmsn, meanwhile or otr, and it would be rather annoying to those who don't wish to use it to have it installed just to get Kopete. For Mac users, it would probably be much more useful to have the nowlistening plugin query iTunes rather than XMMS, but that is something I dare not get involved in as it's non-trivial, and I would never use the nowlistening plugin regardless what music player it may interface to.

[jmroot (Joshua Root)]

The variants are gone from kdenetwork4.