Opened 14 years ago
Closed 14 years ago
#26647 closed update (fixed)
mkvtoolnix-4.3.0 maintainer update
Reported by: | ruud@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | maintainer haspatch | Cc: | |
Port: | mkvtoolnix |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
Updated Portfile from 3.2.0 to 4.3.0
There are some additional changes:
- configure patch removed (not in patch, remove manually)
- Builds universal now
- Changed for the packages new build-system (build_deps port:ruby)
- Added default variants according to default configure output
Attachments (2)
Change History (8)
Changed 14 years ago by ruud@…
Attachment: | Portfile-4.3.0.diff added |
---|
comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Description: | modified (diff) |
---|---|
Keywords: | maintainer haspatch added |
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to ryandesign@… |
---|---|
Status: | new → assigned |
comment:3 follow-up: 4 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
According to "otool -L", mkvtoolnix ended up linked with libmagic.1.dylib, which is provided by the file port, though no library dependency on the file port was declared. It also ended up linked with libintl.8.dylib, which is provided by the gettext port, though no library dependency on gettext was declared. And even when I disable the bzip2 and lzo variants, it ends up linked with libbz2.1.0.dylib and liblzo2.2.dylib.
bzip2, lzo and file are not large ports; on my 3-year-old MacBook Pro, bzip2 took 4 seconds to build, lzo took 37 seconds, and file took 30 seconds. even flac only takes 90 seconds to build. These are negligible compared to the 9 minutes mkvtoolnix took to build. So we can dispense with the variants entirely and just declare the dependencies in the main part of the port.
gettext is not small, but is already an indirect dependency through lzo's build dependency on autoconf, and everybody will have gettext installed anyway since so many ports use it.
I'm attaching a revised update proposal; does this look ok to you?
Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | mkvtoolnix-ryandesign.diff added |
---|
proposed patch
comment:4 Changed 14 years ago by ruud@…
Replying to ryandesign@…:
According to "otool -L", mkvtoolnix ended up linked with libmagic.1.dylib, which is provided by the file port, though no library dependency on the file port was declared. It also ended up linked with libintl.8.dylib, which is provided by the gettext port, though no library dependency on gettext was declared. And even when I disable the bzip2 and lzo variants, it ends up linked with libbz2.1.0.dylib and liblzo2.2.dylib.
I'm attaching a revised update proposal; does this look ok to you?
Odd that I didn't notice that before, though nothing is mentioned in the (on-line) dependency list. But your changes look good.
comment:5 Changed 14 years ago by jmroot (Joshua Root)
Reporter: | changed from ruud@… to ruud@… |
---|
comment:6 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
On Snow Leopard, with the +universal variant, configure says:
According to "./configure --help", "--enable-bzip2" should be "--enable-bz2" so I'll change that.
The universal build says:
(and stops there) so I won't reenable the universal variant at this time. If you can make the universal variant work, please supply a new patch.