mnogosearch: add postgresql84 variant

[dbraband@…]

New variant postgresql84 for mnogosearch

[jmroot (Joshua Root)]

You don't need to increment the revision when you're just adding a variant.

[ryandesign (Ryan Carsten Schmidt)]

patch-locations_configure.in (neither the version in this ticket nor the one already in use by the port) is not implemented correctly. It makes it so that include/pgsql, and include/postgresql83, and include/postgresql84, are all simultaneously added to the include paths, and the last one found is used, and similarly for library paths. This means that a user who has both postgresql83 and postgresql84 installed, and requests the postgresql83 variant of mnogosearch, will unexpectedly get mnogosearch built with postgresql84:

$ port installed name:postgresql8
The following ports are currently installed:
  postgresql81 @8.1.22_0 (active)
  postgresql83 @8.3.12_0 (active)
  postgresql84 @8.4.5_0+universal (active)
$ sudo port install mnogosearch +postgresql83
--->  Computing dependencies for mnogosearch
--->  Fetching mnogosearch
--->  Verifying checksum(s) for mnogosearch
--->  Extracting mnogosearch
--->  Applying patches to mnogosearch
--->  Configuring mnogosearch


-------------------------------------------------------------
Note:  if you did not select any database variants, mnogosearch
will be built without the indexer (which may not be what you
wanted).
-------------------------------------------------------------


--->  Building mnogosearch
--->  Staging mnogosearch into destroot
--->  Installing mnogosearch @3.3.8_1+postgresql83
--->  Activating mnogosearch @3.3.8_1+postgresql83
--->  Cleaning mnogosearch
$ otool -L /opt/local/bin/mconv
/opt/local/bin/mconv:
	/opt/local/lib/libmnogosearch-3.3.dylib (compatibility version 0.0.0, current version 0.0.0)
	/opt/local/lib/libmnogocharset-3.3.dylib (compatibility version 0.0.0, current version 0.0.0)
	/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
	/opt/local/lib/postgresql84/libpq.5.dylib (compatibility version 5.0.0, current version 5.2.0)
	/opt/local/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/opt/local/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.2.0)

Is patching and autoreconfing necessary at all? Can't we just, in each postgresql variant, pass the PGSQL_INCDIR and PGSQL_LIBDIR values we want, and similarly in the mysql variants? If not, and patching is the only way, then each variant should probably get its own distinct patchfile that sets the paths properly for that variant only.

[ryandesign (Ryan Carsten Schmidt)]

Added your postgresql84 variant in r73862 since it's no worse than what's already in the portfile. My objections above remain.