Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#27155 closed defect (fixed)

VLC 1.0.6 build failure - librsvg-2/librsvg/rsvg.h: No such file or directory

Reported by: lev_@… Owned by: mnick@…
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc:
Port: VLC

Description

The VLC's latest version available on MacPorts 1.0.6 doesn't upgrade on a MacBook Pro running Mac OS 10.6.4. I attached the debug output and the log files.

Thanks for all the interested parties.

Attachments (3)

vlc-error.txt (156.9 KB) - added by lev_@… 14 years ago.
vlc-log.txt (18.7 KB) - added by lev_@… 14 years ago.
patch-svg.c.diff (386 bytes) - added by ak.ml@… 14 years ago.
Quick patch for svg.c

Download all attachments as: .zip

Change History (10)

Changed 14 years ago by lev_@…

Attachment: vlc-error.txt added

Changed 14 years ago by lev_@…

Attachment: vlc-log.txt added

comment:1 Changed 14 years ago by mf2k (Frank Schima)

Keywords: vlc upgrade removed
Owner: changed from macports-tickets@… to mnick@…

comment:2 Changed 14 years ago by jmroot (Joshua Root)

Summary: VLC 1.0.6 doesn't upgradeVLC 1.0.6 build failure - librsvg-2/librsvg/rsvg.h: No such file or directory

comment:3 Changed 14 years ago by ak.ml@…

The include dir of librsvg has changed from "${prefix}/include/librsvg-2" to "${prefix}/include/librsvg-2.0".
modules/misc/svg.c has an hardcoded include to librsvg-2:

$ cd "`port work VLC`/vlc-1.0.6"
$ find . -type f -name '*.c' -print0 | xargs -0 egrep -n -e 'librsvg-2/'
./modules/misc/svg.c:53:#include <librsvg-2/librsvg/rsvg.h>

#include <librsvg/rsvg.h> should be enough

$ cat patch-svg.c.diff 
--- modules/misc/svg.c.orig	2010-11-25 22:20:40.000000000 +0100
+++ modules/misc/svg.c	2010-11-25 22:21:02.000000000 +0100
@@ -50,7 +50,7 @@
 #include <glib.h>
 #include <glib/gstdio.h>
 #include <glib-object.h>                                  /* g_object_unref( ) */
-#include <librsvg-2/librsvg/rsvg.h>
+#include <librsvg/rsvg.h>
 
 typedef struct svg_rendition_t svg_rendition_t;
 

Changed 14 years ago by ak.ml@…

Attachment: patch-svg.c.diff added

Quick patch for svg.c

comment:4 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Port: VLC added; vlc removed

VLC 1.0.6 is old anyway and should be updated; see #25431.

comment:5 in reply to:  description Changed 14 years ago by lev_@…

The version 1.0.6 (the latest version available on MacPorts) now builds after a new "portaudio" port.

This ticket can now be closed as resolved.

Thanks to all involved.

comment:6 Changed 13 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

Closing as per comment:5.

comment:7 Changed 13 years ago by jmroot (Joshua Root)

The commit that fixed this was r76936 BTW.

Note: See TracTickets for help on using tickets.