Opened 14 years ago
Closed 14 years ago
#27417 closed update (fixed)
uni2ascii should be updated to 4.15
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | mww@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | haspatch | Cc: | |
| Port: | uni2ascii |
Description
uni2ascii 4.15 is out so the port should probably be updated to this version.
I attempted an update but encountered problems due to them having removed getline() from their sources, claiming it is a standard part of POSIX. I will investigate a little further and then attach what I have as a patch. In any case, my patch will be based on the assumption that the patch in #27408 has already been committed.
Attachments (1)
Change History (3)
Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | uni2ascii-4.15.diff added |
|---|
comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|
Here is a patch to update the port to 4.15. It works for me. It includes a patch to ascii2uni.c which brings back the chunk of code deleted upstream between 4.14 and 4.15 that implements the getline() function. The developer deleted it from the code, according to the ChangeLog, "since getline is standard as of POSIX2008", but it appears that not even Snow Leopard implements POSIX2008, so this code removal seems to be about 5 or 6 years premature IMHO, and the developer should be informed he should put it back in until everyone uses POSIX2008-compliant operating systems.
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed in r73852 (maintainer timeout).
proposed patch