#27479 closed defect (fixed)
mozplugger builds universal even when the universal variant was not requested
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | jeremyhu (Jeremy Huddleston Sequoia) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.2 |
Keywords: | Cc: | ||
Port: | mozplugger |
Description
$ sudo port install mozplugger -universal Password: ---> Fetching mozplugger ---> Attempting to fetch mozplugger-1.14.2.tar.gz from http://distfiles.macports.org/mozplugger ---> Verifying checksum(s) for mozplugger ---> Extracting mozplugger ---> Configuring mozplugger ---> Building mozplugger ---> Staging mozplugger into destroot ---> Installing mozplugger @1.14.2_0 ---> Activating mozplugger @1.14.2_0 ---> Cleaning mozplugger $ port -v installed mozplugger The following ports are currently installed: mozplugger @1.14.2_0 (active) platform='darwin 10' archs='x86_64' $ port -q contents mozplugger | grep /bin/ | xargs lipo -info Architectures in the fat file: /opt/local/bin/mozplugger-controller are: x86_64 i386 Architectures in the fat file: /opt/local/bin/mozplugger-helper are: x86_64 i386 Architectures in the fat file: /opt/local/bin/mozplugger-linker are: x86_64 i386 $
r73886 caused this, because it unconditionally uses ${configure.universal_whatever}. These should only be used if the universal variant is selected. And their non-universal counterparts should be used in the other case, to support changing the build_arch.
Attachments (1)
Change History (6)
comment:1 Changed 14 years ago by jeremyhu (Jeremy Huddleston Sequoia)
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | fixed |
---|---|
Status: | closed → reopened |
They're always set.
You also need to actually create a universal variant, as in the attached patch.
Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | mozplugger-universal.diff added |
---|
proposed patch
comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Ah, it's openmaintainer; I fixed it in r73905.
comment:4 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to ryandesign@…:
And their non-universal counterparts should be used in the other case, to support changing the build_arch.
Fixed this in r73906.
comment:5 Changed 7 years ago by mrkapqa
Hello , i installed this on Osx Lion , but it won't show up in Firefox Plugins.
Note: See
TracTickets for help on using
tickets.
I thought those were only set if we were +universal...
r73898