bitlbee @3.0.1 build breaks if libproxy is installed

[chris@…]

The bitlbee configure script sets its cpppath to look in /opt/local/include before looking inside the bitlbee workdir, so if you have libproxy installed, /opt/local/include/proxy.h will shadow bitlbee's working directory lib/proxy.h, and the build will explode.

The attached patch isn't pretty, but it fixes the problem in what I think is a minimally invasive way.

For the sake of people searching, here's the telltale bit in the build output:

--->  Computing dependencies for bitlbee.
--->  Building bitlbee
* Compiling bitlbee.c
* Compiling dcc.c
In file included from bitlbee.h:136,
                 from bitlbee.c:27:
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_irc_bitlbee/work/bitlbee-3.0.1/protocols/nogaim.h:334: error: expected declaration specifiers or '...' before 'b_input_condition'
In file included from bitlbee.h:136,
                 from dcc.c:25:
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_irc_bitlbee/work/bitlbee-3.0.1/protocols/nogaim.h:334: error: expected declaration specifiers or '...' before 'b_input_condition'
In file included from bitlbee.c:27:
bitlbee.h:163: error: expected declaration specifiers or '...' before 'b_input_condition'
In file included from dcc.c:25:
bitlbee.h:163: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.h:164: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.h:164: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.h:169: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.h:169: error: expected declaration specifiers or '...' before 'b_input_condition'bitlbee.h:170: error: expected declaration specifiers or '...' before 'b_input_condition'

bitlbee.h:170: error: expected declaration specifiers or '...' before 'b_input_condition'
In file included from bitlbee.c:31:
ipc.h:48: error: expected declaration specifiers or '...' before 'b_input_condition'
ipc.h:49: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.c:36: error: expected declaration specifiers or '...' before 'b_input_condition'
dcc.c:65: error: expected declaration specifiers or '...' before 'b_input_condition'
dcc.c:67: error: expected declaration specifiers or '...' before 'b_input_condition'
dcc.c:69: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.c: In function 'bitlbee_daemon_init':
bitlbee.c:123: warning: implicit declaration of function 'b_input_add'
bitlbee.c:123: error: 'B_EV_IO_READ' undeclared (first use in this function)
bitlbee.c:123: error: (Each undeclared identifier is reported only once
bitlbee.c:123: error: for each function it appears in.)
dcc.c: In function 'dccs_send_start':
dcc.c:118: warning: implicit declaration of function 'b_input_add'
dcc.c:118: error: 'B_EV_IO_READ' undeclared (first use in this function)
dcc.c:118: error: (Each undeclared identifier is reported only once
dcc.c:118: error: for each function it appears in.)
dcc.c:122: warning: implicit declaration of function 'b_timeout_add'
bitlbee.c: At top level:
bitlbee.c:186: error: expected declaration specifiers or '...' before 'b_input_condition'
dcc.c: At top level:
dcc.c:155: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.c:241: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.c:288: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.c: In function 'bitlbee_io_new_client':
bitlbee.c:325: error: 'B_EV_IO_READ' undeclared (first use in this function)
bitlbee.c:343: warning: implicit declaration of function 'b_main_init'
bitlbee.c:347: warning: implicit declaration of function 'b_event_remove'
bitlbee.c: At top level:
bitlbee.c:371: error: expected declaration specifiers or '...' before 'b_input_condition'
bitlbee.c: In function 'bitlbee_shutdown':
bitlbee.c:379: warning: implicit declaration of function 'b_main_quit'
dcc.c:225: error: expected declaration specifiers or '...' before 'b_input_condition'
dcc.c: In function 'dccs_send_proto':
dcc.c:230: error: 'cond' undeclared (first use in this function)
dcc.c:230: error: 'B_EV_IO_READ' undeclared (first use in this function)
dcc.c: In function 'dccs_recv_start':
dcc.c:327: error: 'B_EV_IO_WRITE' undeclared (first use in this function)
dcc.c: At top level:
dcc.c:335: error: expected declaration specifiers or '...' before 'b_input_condition'
dcc.c: In function 'dccs_recv_proto':
dcc.c:340: error: 'cond' undeclared (first use in this function)
dcc.c:340: error: 'B_EV_IO_WRITE' undeclared (first use in this function)
dcc.c:351: error: 'B_EV_IO_READ' undeclared (first use in this function)
dcc.c:385: warning: implicit declaration of function 'b_event_remove'
dcc.c: In function 'dccs_recv_write_request':
dcc.c:408: error: 'B_EV_IO_READ' undeclared (first use in this function)
dcc.c: At top level:
dcc.c:413: error: expected declaration specifiers or '...' before 'b_input_condition'
dcc.c: In function 'dccs_send_write':
dcc.c:451: error: 'B_EV_IO_WRITE' undeclared (first use in this function)
make: *** [bitlbee.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [dcc.o] Error 1

[chris@…]

Updated patch-configure.diff that fixes the problem

[jmroot (Joshua Root)]

Please remember to cc the maintainer.

[neverpanic (Clemens Lang)]

Fixed in r83543 using a method already present in the nodejs port.