Web Polygraph

[fclaire@…]

Here's a port of the famous Web Polygraph benchmark software

​http://www.web-polygraph.org/

[ryandesign (Ryan Carsten Schmidt)]

Thanks.

[ryandesign (Ryan Carsten Schmidt)]

I committed the port in r74213 with the exception that I deleted the following lines, which have no purpose in this port:

variant universal {}
if {[variant_isset universal]} {
    set archflags       ${configure.universal_cflags}
} else {
    set archflags       ${configure.cc_archflags}
}

In these lines, you're setting the archflags variable to a value depending on whether the universal variant is set... but then you don't ever actually use the archflags variable anywhere.

I imagine you probably copied these lines from another port where they did have a purpose. That other port probably also included a line that made use of the archflags variable, for example:

build.args              CC="${configure.cc} ${archflags}"

This would pass the archflags, along with the compiler name, to the CC environment variable, which would be used by the software's Makefiles. This manual setting of the archflags is necessary to add universal and non-default-build_arch support to ports for software that does not use a standard configure script. Since polygraph does use a standard configure script, there's no need to do this manually; MacPorts already handles it automatically by passing the necessary environment variables to the configure script during the configure phase.

[fclaire@…]

Thanks a lot for comitting this port and for your useful comments about the universal variant.

Indeed I used a Portfile from one of my previous ports (metapixel) and I just left this universal variant in it without even wondering what it was. You're right: it's useless.

About the patch I'm now going to propose it to the polygraph development team.