Opened 14 years ago
Closed 13 years ago
#27813 closed defect (fixed)
MacVim requires download of EnvyCodeR font during build phase
Reported by: | scott.macports@… | Owned by: | raimue (Rainer Müller) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.2 |
Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt), BlackFrog1, robink@…, randomtoor@… | |
Port: | MacVim |
Description (last modified by mf2k (Frank Schima))
sudo port -v install MacVim
fails on
curl http://download.damieng.com/latest/EnvyCodeR --location -o EnvyCodeR.zip
as that url does not appear to be available.
Attachments (2)
Change History (14)
comment:1 Changed 14 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|---|
Owner: | changed from macports-tickets@… to raimue@… |
Port: | MacVim added |
comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|
comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
...except that the notice on the author's web site says "These files are free to download and use from damieng.com but CAN NOT be redistributed either by other web sites or be included in your package, download, product or source repository at this time." So, screw it.
Scott, please try installing the port again. It works fine here. If it fails again, see if you can get to the download URL in a web browser.
comment:4 Changed 14 years ago by raimue (Rainer Müller)
Status: | new → assigned |
---|
Yes, the situation is not ideal. A possible solution could be to ship a pre-compiled icon set instead of generating these at build time, therefore eliminating the need to download the font.
comment:5 Changed 14 years ago by BlackFrog1
The old url to download the EnvyCodeR was removed. A branch of the source has been patched to reflex that changed. I have created a patch to the current snapshot that can be used. Please find it attached.
Changed 14 years ago by BlackFrog1
Attachment: | patch-src-MacVim-icons-Makefile.diff added |
---|
Patch Envy Code R font download url
Changed 14 years ago by BlackFrog1
Attachment: | Portfile-MacVim.diff added |
---|
Portfile patch to include update the URL for the Envy Code R font
comment:7 Changed 14 years ago by raimue (Rainer Müller)
Thank you for the patch. Build fix committed in r76470.
comment:8 Changed 14 years ago by raimue (Rainer Müller)
Summary: | install MacVim fails due to EnvyCodeR download failing → MacVim requires download of EnvyCodeR font during build phase |
---|
comment:10 Changed 14 years ago by rrbarbosa@…
I have a related problem. The patch seems to work in the sense that the correct file is downloaded, but the downloaded files are not builded correctly in my machine:
touch Envy\ Code\ R\ Bold.ttf make -C makeicns cc -fpascal-strings -O2 -c -o makeicns.o makeicns.m cc -fpascal-strings -O2 -c -o IconFamily.o IconFamily.m cc -fpascal-strings -O2 -c -o NSString+CarbonFSRefCreation.o NSString+CarbonFSRefCreation.m g++ -o makeicns makeicns.o IconFamily.o NSString+CarbonFSRefCreation.o -O2 \ -framework Foundation -framework AppKit -framework Carbon /opt/local/bin/python2.7 make_icons.py /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_editors_MacVim/work/MacVim/src/MacVim/build/Release/MacVim.app/Contents/Resources No module named AppKit PyObjC not found, only using a stock icon for document icons. Touch build/Release/MacVim.app cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_editors_MacVim/work/MacVim/src/MacVim /usr/bin/touch -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_editors_MacVim/work/MacVim/src/MacVim/build/Release/MacVim.app
I don't know if it is important, but the macvim wiki also notes that the icons should be built before macvim itself: https://github.com/b4winckler/macvim/wiki/Building
comment:12 Changed 13 years ago by raimue (Rainer Müller)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The font is no longer required, see upstream commit.
The URL is available; the port installs fine for me. However, your bug report points out that MacVim's Makefile uses curl to download a file; this is not proper behavior for MacPorts. We should download this file during the fetch phase, checksum it properly, and put it where MacVim wants it.