Opened 14 years ago
Closed 9 years ago
#28069 closed defect (fixed)
Pidgin 2.7.9: Menu bar icon does not change
| Reported by: | jemaltz@… | Owned by: | dbevans (David B. Evans) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | nefar@… | |
| Port: | pidgin |
Description
After upgrading to Pidgin 2.7.9, I have noticed that the menu bar icon does not change past the "connecting" icon. This includes successfully establishing a connection, as well as changing one's status to away, and then reverting back to the available status. Through it all, the icon stays "connecting".
I am using Mac OS X 10.6.6 (64-bit Macbook Pro), and I complied Pidgin with +no_x11 +quartz
Attachments (3)
Change History (12)
comment:1 Changed 13 years ago by jemaltz@…
comment:2 Changed 13 years ago by nefar@…
Just to let everyone know I've seen this, I don't know what the problem is. Patches are welcome. I'm just making sure the ports stays updated, but I'm not in a position where I can fix bugs with things going wrong.
comment:3 Changed 13 years ago by maristgeek@…
Still happening in 2.9.0. My icon is showing connected, but does not change for anything.
Mac OS X 10.6.8 (64-bit MacBook Pro), compiled with +no_x11 +quartz
comment:4 Changed 13 years ago by jemaltz@…
I dug a bit deeper, and this began happening after changes to pidgin/gtkdocklet-gtk.c in Pidgin 2.7.8 (specifically, with this Pidgin ticket, http://developer.pidgin.im/ticket/12129). I reversed those changes, and the docklet icon works correctly again (in my limited testing).
This is obviously not a proper (or good) fix, as ideally the upstream code update would be fixed instead of reverted, but for the time being, this at least restores the broken functionality.
Changed 13 years ago by jemaltz@…
| Attachment: | Portfile-pidgin.diff added |
|---|
Updated Pidgin 2.10.3 Portfile, with docklet fix
Changed 13 years ago by jemaltz@…
| Attachment: | patch-pidgin-gtkdocklet-gtk.c.diff added |
|---|
comment:5 Changed 13 years ago by jemaltz@…
Updated patch is a real patch instead of a reversion. I suspected that there was a problem with GtkStatusIcon sending an "embedded" notify signal, which the Pidgin code utilizes for GTK+ 2.12.0 and higher, while it uses gtk_status_icon_is_embedded() to check the docklet's embedded status for lower versions. So, I removed the GTK+ version check in that area of the code, forcing gtk_status_icon_is_embedded() to run regardless of GTK+ version. This seems to work once again on OS X, and until the Pidgin folk say otherwise, I would go with this patch for fixing the broken docklet in OS X.
Changed 13 years ago by jemaltz@…
| Attachment: | patch-pidgin-gtkdocklet-gtk.c.2.diff added |
|---|
Updated patch, with GTK+ version check removed (see comments)
comment:6 Changed 10 years ago by jmroot (Joshua Root)
| Owner: | changed from macports-tickets@… to devans@… |
|---|
comment:7 Changed 9 years ago by jmroot (Joshua Root)
Is this still a problem with the current version? Was the patch sent upstream?
comment:8 Changed 9 years ago by dbevans (David B. Evans)
Don't know. Will check current version and see.
comment:9 Changed 9 years ago by dbevans (David B. Evans)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
| Version: | 1.9.2 |
Confirming that the reported issue still exists in pidgin 2.10.11 and that the patch submitted here fixes the problem.
Committed in r139231 and reported upstream with patch in pidgin ticket #16738.
Thanks for the ticket. Sorry it's been overlooked for so long.
Still happens with the #29834 update to 2.8.0.