Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#28090 closed defect (fixed)

mtpaint 3.20 fails to build after libpng 1.4.5 update

Reported by: ak.ml@… Owned by: afb@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: png Cc:
Port: mtpaint

Description

:info:build ld warning: option -s is obsolete and being ignored
:info:build Undefined symbols:
:info:build   "_png_set_gray_1_2_4_to_8", referenced from:
:info:build       _load_png in png.o
:info:build       _load_png in png.o
:info:build ld: symbol(s) not found
:info:build collect2: ld returned 1 exit status
:info:build make[1]: *** [mtpaint] Error 1
:info:build make: *** [src] Error 2

According to the libpng ChangeLog http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt:

2. m. The function png_set_gray_1_2_4_to_8() was removed. It has been
      deprecated since libpng-1.0.18 and 1.2.9, when it was replaced with
      png_set_expand_gray_1_2_4_to_8() because the former function also
      expanded palette images.

I've updated src/png.c where png_set_gray_1_2_4_to_8 is used and it compiles fine.

Ihave a MacIntel with Leopard 10.5.8

Attachments (2)

mtpaint-3.20.log (91.2 KB) - added by ak.ml@… 14 years ago.
patch-png.c.diff (662 bytes) - added by ak.ml@… 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by ak.ml@…

Attachment: mtpaint-3.20.log added

Changed 14 years ago by ak.ml@…

Attachment: patch-png.c.diff added

comment:1 Changed 14 years ago by jmroot (Joshua Root)

Cc: afb@… removed
Keywords: png added; libpng removed
Owner: changed from macports-tickets@… to afb@…

comment:2 Changed 14 years ago by afb@…

Cc: waqar@… removed
Resolution: fixed
Status: newclosed
Version: 1.9.2

Fixed, r75339.

comment:3 Changed 14 years ago by ak.ml@…

$ port info --maintainer libpng
maintainer: ryandesign@macports.org, waqar@macports.org

Hence waqar

comment:4 Changed 14 years ago by afb@…

Cc: ryandesign@… removed

Removed waqar after the complaints, should have removed ryan too.

Note: See TracTickets for help on using tickets.