Opened 14 years ago
Closed 14 years ago
#28131 closed submission (fixed)
p5-css: new port
Reported by: | ejshamow@… | Owned by: | l2g@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | p5-css |
Description
Submitting a Portfile generated by cpan2port, with minimal editing (port description and maintainer)
Attachments (1)
Change History (5)
Changed 14 years ago by ejshamow@…
comment:1 Changed 14 years ago by l2g@…
Owner: | changed from macports-tickets@… to l2g@… |
---|---|
Port: | p5-css added |
Summary: | p5-css @1.08 not available → p5-css: new port |
Version: | 1.9.2 |
comment:2 Changed 14 years ago by ejshamow@…
My apologies for the newbie errors --
If you could update the maintainer information that would be fantastic -- I'm more than happy to volunteer as maintainer for this, and also for the html-wikiconverter group of ports.
If there's a resource or resources you recommend I read for general improvements that can be made (or how to test for them) in cpan2port output I'd appreciate it - or would just becoming more familiar with the Portfile format be the general recommendation? I have plenty of stuff I'm willing to port and maintain, but want to make sure I'm not generating more work for others.
comment:3 Changed 14 years ago by l2g@…
Status: | new → assigned |
---|
(Oops, I was going to take ownership of this ticket but I forgot.)
Don't feel bad about the newbie errors. Everyone starts as a newbie--even I. :-)
For understanding portfiles, my best friends have been the MacPorts Guide (http://guide.macports.org/) and the MacPorts Development section of the wiki (http://trac.macports.org/wiki).
comment:4 Changed 14 years ago by l2g@…
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The bug ticket on Perl's RT included a script for rebuilding the buggy Perl module, so I'm including it in this port. CSS tests and passes now (port test p5-css
).
I've committed it to Subversion (r75727). If you (ejshamow) want to have any changes made and you file a ticket to do so, remember to include the keyword "maintainer" in your ticket, and the keyword "haspatch" if you attach one or more patches to the ticket.
A note for the public record: This is important because p5-html-wikiconverter (and by extension the entire p5-html-wikiconverter-* family) depends on it.
I'm going to rework the portfile from scratch in order to work around a tricky problem: an earlier bug in Parse::RecDescent caused some generated grammar-parsing code within the CSS.pm distro to be buggy (see https://rt.cpan.org/Public/Bug/Display.html?id=53948) --but the author of CSS.pm hasn't yet released a version with rebuilt code.
I discovered this problem when running
port -d test p5-css
.Please don't be shy about editing portfiles generated by cpan2port. The cleanup is extra work, but if you don't do it, someone else will have to do it anyway. :-) In particular, I find that the
extract.suffix
andmaster_sites
lines it generates are almost always unnecessary because the perl5 portgroup already has reasonable defaults for these.Do you still want to volunteer as maintainer of this when it's ready? You entered
eshamow
as the maintainer, which implies that your email address is eshamow@…. If you really want to use your Gmail address, I can change it togmail.com:ejshamow
(the customary format for maintainers with non-macports.org addresses).