Opened 14 years ago
Closed 14 years ago
#28318 closed defect (fixed)
p5-locale-gettext: fix for POSIX locale conflict
Reported by: | l2g@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | |
Port: | p5-locale-gettext |
Description
When running quilt's refresh
command, I ran into some strange warning messages. To be brief, this turns out to be a known bug in Locale::gettext that has been reported to upstream (CPAN RT #35806). A fix was contributed by the Debian Project almost three(!) years ago, but it has yet to be incorporated by the author.
The symptom is a string of "Prototype mismatch" warning messages similar to the following example:
Prototype mismatch: sub main::LC_ALL: none vs () at /opt/local/share/quilt/scripts/remove-trailing-ws line 21 Prototype mismatch: sub main::LC_NUMERIC: none vs () at /opt/local/share/quilt/scripts/remove-trailing-ws line 21 Prototype mismatch: sub main::LC_TIME: none vs () at /opt/local/share/quilt/scripts/remove-trailing-ws line 21 Prototype mismatch: sub main::LC_MONETARY: none vs () at /opt/local/share/quilt/scripts/remove-trailing-ws line 21 Prototype mismatch: sub main::LC_CTYPE: none vs () at /opt/local/share/quilt/scripts/remove-trailing-ws line 21 Prototype mismatch: sub main::LC_MESSAGES: none vs () at /opt/local/share/quilt/scripts/remove-trailing-ws line 21 Prototype mismatch: sub main::LC_COLLATE: none vs () at /opt/local/share/quilt/scripts/remove-trailing-ws line 21
I'm attaching a patch for this port's existing files, and I'm directly attaching two new files that are additional patches applied during the port's patch phase. I'd like some input on whether these changes look reasonable. If so, I can commit them.
Attachments (4)
Change History (6)
Changed 14 years ago by l2g@…
Attachment: | tmo28138.p5-locale-gettext.patch added |
---|
Changed 14 years ago by l2g@…
Attachment: | patch-cpan-rt-35680-1.diff added |
---|
Additional diff for the port's patch phase
Changed 14 years ago by l2g@…
Attachment: | patch-cpan-rt-35680-2.diff added |
---|
Additional diff for the port's patch phase
Changed 14 years ago by l2g@…
Attachment: | tmo28318.p5-locale-gettext.patch added |
---|
Patch for existing port files--this time with the right file name
comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)
Based on the comment in the patch, this would only be a problem if using perl > 5.10?
If it fixes a problem for perl 5.12 and doesn't cause new ones for perl 5.8 and 5.10, then go for it.
comment:2 Changed 14 years ago by l2g@…
Resolution: | → fixed |
---|---|
Status: | new → closed |
I committed the changes a couple of weeks ago (r76661). Sorry I did not note this here sooner.
Patch for existing port files