Opened 14 years ago

Closed 14 years ago

#28356 closed enhancement (fixed)

eggdrop: minimize use of "system"

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: dreness (Andre LaBranche)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: BlackFrog1
Port: eggdrop

Description

The eggdrop portfile includes this line: 

post-destroot	{ system "cd ${destroot}${prefix}/bin/ && rm ../share/eggdrop/eggdrop && ln -s ../share/eggdrop/eggdrop-${version} eggdrop && mv ../share/eggdrop/eggdrop.conf ../share/eggdrop/eggdrop.conf.sample && mv ../share/eggdrop/doc/man1/eggdrop.1 ../share/man/man1"

All of this can be done with native Tcl commands, which is preferable to using "system".

Attachments (1)

Portfile-eggdrop.diff​ (960 bytes) - added by BlackFrog1 14 years ago.
system command converted into tcl extension

Download all attachments as: .zip

Change History (4)

comment:1 Changed 14 years ago by BlackFrog1

Cc: blackfrog1@… added

Cc Me!

comment:2 Changed 14 years ago by BlackFrog1

I took each of the system command and converted them into the Tcl Extension. See attached port patch diff.

Changed 14 years ago by BlackFrog1

Attachment: Portfile-eggdrop.diff​ added

system command converted into tcl extension

comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: new → closed

Thanks, r77379 (maintainer timeout).

Note: See TracTickets for help on using tickets.