Generated Installer pkgs should not have '&' in IFPkgDescriptionDescription

[pucklock@…]

Portfiles must exclude the use of ampersand (&) in description field because Installer.app packages become corrupted and un-installable. The unrar portfile is an example (but there was 1 other a while ago, I just didn't know the fix, and can't remember):

port pkg unrar -v

will compile and package up just fine, but you will get "Welcome to %@ installer" in Installer.app - and you have to quit out, you are locked out of pressing any buttons. The portfile description field gets embedded into the packages some_package.pkgContents/Resources/Description.plist in the IFPkgDescriptionDescription key. It is this key that causes the problem. Changing the "&" there to "and" fixes the package - so changing the portfile will do/does the same.

fake, pseudo diff -u archivers/unrar :

---

# $Id: Portfile,v 1.8 2005/04/04 13:48:36 toby Exp $

PortSystem 1.0 name unrar version 3.5.1 categories archivers maintainers max@… -description Extract, view & test RAR archives +description Extract, view and test RAR archives

ps, I emailed toby the day after he made this portfile, and I posted this in the irc channel.

[toby@…]

Why not fix the packaging stuff? & is a total valid character for Portfiles.

[pucklock@…]

(In reply to comment #1)

Why not fix the packaging stuff? & is a total valid character for Portfiles.

& may be valid for portfiles, but it is NOT valid in the IFPkgDescriptionDescription key of ANY package. Go add "&" to that key into a non-Darwinports package & see what happens - its an Apple Installer.app limitation.

[snu@…]

This is surely a base bug.

[cjr@…]

Patch for portpkg.tcl and portmpkg.tcl

[cjr@…]

Revised patch to base

[cjr@…]

Can anyone with a base commit bit please review and (hopefully) apply this?

[olegb@…]

Thanks Chris ...