Opened 14 years ago

Last modified 11 years ago

#28764 new submission

HDRSee portfile

Reported by: pac@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: hdrsee

Description

Dear Sir,

We would like to have add a portfile for HDRSee which is a CPU/GPU software to display LDR/HDR images.

More info are available here: http://mhdrviewer.gforge.inria.fr/

Thank you,

Cheers Romain

Attachments (2)

hdrsee_portfile_test.txt (3.3 KB) - added by pac@… 14 years ago.
Portfile (3.0 KB) - added by pac@… 11 years ago.
The new portfile that needs to be validated

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by pac@…

Attachment: hdrsee_portfile_test.txt added

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Port: hdrsee added
Version: 1.9.2

Output of port lint on the attachment:

% port lint
--->  Verifying Portfile for hdrsee
Warning: Line 32 should say "use_configure no" instead of declaring an empty configure phase
Error: Missing required variable: platforms
Warning: no license set
--->  1 error and 2 warnings found.

Additional notes after reviewing the attachment:

  • Is scons really needed at runtime? If not, it should be in depends_build, not depends_lib.
  • You shouldn't use arch=nocona unconditionally. Check what arch you are actually building on.
  • You need to use ${prefix} instead of hardcoding /opt/local in the include and libpath args.
  • You should not use puts. If you must print a message directly, ui_msg is better, but generally all notes for the user should go in the 'notes' variable.
  • Users should never have to set DYLD_LIBRARY_PATH. Any program that requires it to be set outside of a testing/debugging environment is linked incorrectly.

Sorry it's taken so long for this to be reviewed, but tickets that are not assigned to anyone can easily fall through the cracks. If it appears that a ticket has been forgotten, you can email the macports-dev list.

comment:2 Changed 11 years ago by pac@…

Here is a new portfile that fits the new release of HDRSee (0.65)

Changed 11 years ago by pac@…

Attachment: Portfile added

The new portfile that needs to be validated

comment:3 Changed 11 years ago by pac@…

Hi,

Could I have an answer please ?

Many thanks

Best Regards,

comment:4 in reply to:  3 Changed 11 years ago by larryv (Lawrence Velázquez)

Email macports-dev to try getting a committer’s attention.

Note: See TracTickets for help on using tickets.