#28985 closed enhancement (fixed)
glib2 does not need dbus
| Reported by: | tvb377@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | haspatch | Cc: | su-v |
| Port: | glib2 |
Description
As a follow up to #26711: glib2 and at least some of the ports that use it do not need dbus at all.
Attached is a patch that declares a no_dbus variant.
Attachments (1)
Change History (7)
Changed 14 years ago by tvb377@…
| Attachment: | glib2-Portfile.patch added |
|---|
comment:1 Changed 14 years ago by su-v
| Cc: | suv-sf@… added |
|---|
comment:2 follow-up: 3 Changed 14 years ago by jmroot (Joshua Root)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Type: | defect → enhancement |
Please remember to cc the maintainer.
This won't be accepted as-is because the variant doesn't prevent the use of dbus if it's already installed. We'd also rather not use variants named like +no_foo, instead, have a default +foo variant that can be turned off.
comment:3 Changed 14 years ago by tvb377@…
Replying to jmr@…:
This won't be accepted as-is because the variant doesn't prevent the use of dbus if it's already installed.
I do not see the problem since it's a build time "independency", I did not find a knob to configure it away, and a comment says "Check for libdbus1 - Optional - is only used in the GDBus test cases".
What about to drop dbus build time dependeny altogether, or turn it into a +dbus variant?
comment:4 Changed 14 years ago by jmroot (Joshua Root)
If it's only used for some tests, turning it off all the time would be reasonable.
comment:5 Changed 13 years ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Cc Me!