Opened 14 years ago

Closed 14 years ago

#29124 closed defect (fixed)

AntTweakBar hardcodes i386 x86_64 archs

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: karcaw@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc:
Port: AntTweakBar

Description

In AntTweakBar, the two files Makefile.osx hardcode the architectures i386 and x86_64. The port should instead have a universal variant, and respect the user's universal_archs and build_arch settings.

Attachments (1)

AntTweakBar-archs.diff​ (1.2 KB) - added by ryandesign (Ryan Carsten Schmidt) 14 years ago.
proposed patch

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: AntTweakBar-archs.diff​ added

proposed patch

comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

I propose the attached patch to fix this. May I commit it? In addition to respecting the user's choice of architecture(s), it uses ${configure.optflags} instead of assuming -O3, and ensures we're UsingTheRightCompiler.

comment:2 Changed 14 years ago by karcaw@…

Thank you for doing that, I have not thought about the arch differences. Please Commit

comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: new → closed

Done in r77820.

Note: See TracTickets for help on using tickets.