Opened 14 years ago
Closed 13 years ago
#29169 closed submission (fixed)
New port: MariaDB 5.2
Reported by: | jogwtr@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.2 |
Keywords: | Cc: | NicosPavlov, ryandesign (Ryan Carsten Schmidt), pixilla (Bradley Giesbrecht) | |
Port: |
Description
New Portfile and patch for MariaDB 5.2
A database server that offers drop-in replacement functionality for MySQL
Attachments (2)
Change History (9)
Changed 14 years ago by jogwtr@…
Changed 14 years ago by jogwtr@…
Attachment: | patch-Makefile.in.diff added |
---|
comment:1 Changed 13 years ago by NicosPavlov
Cc: | nicos@… added |
---|
comment:2 Changed 13 years ago by NicosPavlov
I did take a look at the port, and some points did not seem clear to me:
- As mariadb is not an existing port yet, why name it mariadb52 and not mariadb ?
- It seems to me that the set branch line is not used and could be suppressed.
- I think parallel_build is usually set at yes by default, so that use_parallel_build yes line does not bring anything.
- Shouldn't the first line of master sites
http://mirrors.supportex.net/mariadb/mariadb-5.2.5/kvm-tarbake-jaunty-x86/
be
http://mirrors.supportex.net/mariadb/${distname}/kvm-tarbake-jaunty-x86/
?
- It is considered that md5 hash only is not sufficient. md5, sha1 and rmd160 are default usually.
- As some time passed, I would suggest to update the port directly to last stable version (5.2.9)
Some of these remarks also apply to mariadb52-server port submission (ticket #29170).
I could then add the port, along with with the server port (ticket #29170). It will also be necessary upon addition to request the addition of a conflict to mariadb with mysql* ports.
comment:3 Changed 13 years ago by NicosPavlov
Cc: | ryandesign@… added |
---|
cc to ryandesign for the conflict of this port addition with mysql4, mysql5 and mysql5-devel.
comment:5 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Feel free to add the conflicts to the MySQL ports.
Cc Me!