Opened 14 years ago
Closed 13 years ago
#29238 closed update (fixed)
parrot new version 3.3.0
Reported by: | l2g@… | Owned by: | l2g@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | coke (Will Coleda), bfulgham@… |
Port: | parrot |
Description
Version 3.3.0 of Parrot was released a few days ago (April 19), and it has been designated a "supported" release.
I've played with it by building it and running its tests, and while a number of tests fail that are "TODO" tests, I also get one test failure that isn't a TODO: test number 27 in t/dynpmc/os.t. If I can figure it out before you all do, I will follow up here.
Attachments (2)
Change History (11)
comment:1 Changed 14 years ago by l2g@…
comment:2 Changed 14 years ago by l2g@…
This is the PIR code run by the test:
.sub main :main $P0 = loadlib 'os' $P1 = new ['OS'] $P1.'chdir'('my-super-chroot') $P1.'chroot'('.') $S0 = $P1.'cwd'() say $S0 $P1.'chroot'('loop') .end
So I think the point of the test is just to make sure chroot fails appropriately in event of a loop, not to see how specific the error message is. So if it were me, I'd go ahead and patch the test.
I'll attach the changes I've made: a patch for the portfile, and a new patch to put in the files/ directory.
Changed 14 years ago by l2g@…
Attachment: | Portfile.diff added |
---|
Update parrot to 3.3.0 and include a patch to fix a broken test
Changed 14 years ago by l2g@…
Attachment: | patch-t-dynpmc-os.t.diff added |
---|
New patch to include in lang/parrot/files
comment:3 Changed 14 years ago by l2g@…
Keywords: | haspatch added |
---|
comment:4 follow-up: 6 Changed 13 years ago by coke (Will Coleda)
Opened a ticket in parrot's trac system to track this request 4 weeks ago:
comment:5 Changed 13 years ago by coke (Will Coleda)
Go ahead and apply the patches - We should be able to get the dynpmc patch pushed upstream.
comment:6 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to will@…:
Opened a ticket in parrot's trac system to track this request 4 weeks ago:
I assume you mean:
comment:7 Changed 13 years ago by nerdling (Jeremy Lavergne)
Cc: | bfulgham@… added |
---|---|
Owner: | changed from bfulgham@… to l2g@… |
comment:9 Changed 13 years ago by l2g@…
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I was able to dig down into the test output to find the failure:
So chroot fails, as the test intended, but the error message indicates the cause of failure ("Too many symbolic links"), which the test wasn't expecting.
It may be possible that there's more than one way for chroot to fail here, and that one of them may really not give any reason for the failure. Otherwise, it might be okay just to patch this test to look only as far as "chroot failed" in the error message and call that good.