Opened 13 years ago
Closed 12 years ago
#29509 closed defect (fixed)
ctags: Patch php language specification
| Reported by: | singingwolfboy@… | Owned by: | mww@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | haspatch lack-of-interest | Cc: | ryandesign (Ryan Carsten Schmidt) |
| Port: | ctags |
Description
The php language specification in the ctags port doesn't deal with comments very well. This patch should fix that.
Attachments (1)
Change History (3)
Changed 13 years ago by singingwolfboy@…
| Attachment: | ctags.patch added |
|---|
comment:1 Changed 13 years ago by jmroot (Joshua Root)
| Keywords: | haspatch lack-of-interest added; php removed |
|---|
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| Summary: | Patch php language specification for ctags port → ctags: Patch php language specification |
Note: See
TracTickets for help on using
tickets.
This is the canonical upstream bug report for this issue:
http://sourceforge.net/tracker/?func=detail&aid=1795926&group_id=6556&atid=106556
It says the fix has been committed (three years ago) and will be in the next version after 5.8.0.
The only changes upstream has committed to php.c since that ticket was filed are r729 ("update PHP parser to ignore comments (95% solution)") and r734 ("classes can be final") so I committed those to the ctags port in r100030. I didn't use the patch attached to this ticket. If further changes are needed, please work with the developers of ctags to get the changes into their repository; then we can apply them to the port with the confidence that the developers have approved them.