fossil: i386 build fails on Snow Leopard

[ryandesign (Ryan Carsten Schmidt)]

Trying to build fossil with the universal variant fails:

Undefined symbols for architecture i386:
  "_fossil_fopen$UNIX2003", referenced from:
      _do_meta_command in shell.o
      _do_meta_command in shell.o
      _do_meta_command in shell.o
      _do_meta_command in shell.o
      _sqlite3_shell in shell.o
ld: symbol(s) not found for architecture i386
collect2: ld returned 1 exit status
lipo: can't open input file: /var/tmp//ccijU7Dz.out (No such file or directory)
make: *** [fossil] Error 1

[ci42]

Replying to ryandesign@…:

Trying to build fossil with the universal variant fails:

Please try the attached patch.

[ryandesign (Ryan Carsten Schmidt)]

That does help. But I see now the problem is with the i386 build (on Snow Leopard), regardless whether I'm building universal or just changing build_arch.

The proposed fix of setting MACOSX_DEPLOYMENT_TARGET to 10.5 when it is 10.6 does seem to work, but the problem would probably happen again on Lion when it'll be 10.7. Is there no way to make the software build correctly for i386 when MACOSX_DEPLOYMENT_TARGET is greater than 10.5?

[ci42]

Replying to ryandesign@…:

That does help. But I see now the problem is with the i386 build (on Snow Leopard), regardless whether I'm building universal or just changing build_arch.

The proposed fix of setting MACOSX_DEPLOYMENT_TARGET to 10.5 when it is 10.6 does seem to work, but the problem would probably happen again on Lion when it'll be 10.7. Is there no way to make the software build correctly for i386 when MACOSX_DEPLOYMENT_TARGET is greater than 10.5?

This issue has already been fixed upstream (see ​http://www.fossil-scm.org/fossil/ci/e94c1e9068). The fix is included in #29622.

[ci42]

fixed in r79813