Opened 13 years ago
Closed 13 years ago
#29693 closed enhancement (fixed)
ejabberd: use notes
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | ci42 |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | Cc: | ||
| Port: | ejabberd |
Description
ejabberd has a post-install block that uses ui_msg commands to tell the user about the config files. It would be better to use the newer notes feature for this purpose.
In addition, the message currently printed advises the user to move the sample configuration files. We should not be suggesting that the user should move any file installed by MacPorts. Instead we should suggest they copy the sample configuration files.
The attached patch makes these changes. What do you think? Can we commit this?
Attachments (2)
Change History (6)
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | ejabberd-notes.diff added |
|---|
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | ejabberd-notes.2.diff added |
|---|
proposed patch
comment:1 follow-up: 2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Revised patch makes use of existing portfile variable.
comment:2 follow-up: 3 Changed 13 years ago by ci42
Replying to ryandesign@…:
Revised patch makes use of existing portfile variable.
Please do apply the patches. I already thought about removing the ui_msg commands (they were already there when I took over the port), but I didn't wanted to mix this change with the version update from #29687.
comment:3 Changed 13 years ago by ci42
Replying to ciserlohn@…:
Replying to ryandesign@…:
Revised patch makes use of existing portfile variable.
Please do apply the patches.
I meant, apply the second patch (ejabberd-notes.2.diff)
comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
proposed patch