go portfile creates bad symlinks

[cgilmour@…]

Hi,

Installing "go" creates a symbolic link /src/Make.*, instead of a separate link for each individual make file.

116 # gomake command required makefiles

117 ln -s ${prefix}/src/${name}/${name}-${version}/src/Make.* ${destroot}${prefix}/src

Seems to be related to changes from Ticket #29321

I can't find an example in other Portfiles that tries to make symlinks like this, so I don't have a fix/patch.

(I changed mine to use xinstall instead of making symbolic links, plus other changes to install without root privileges. I think the package maintainer might do it a different way instead)

Thanks Caleb

[ryandesign (Ryan Carsten Schmidt)]

The fix is to use an "eval glob" construct.

[ryandesign (Ryan Carsten Schmidt)]

Or possibly an fs-traverse loop.

[ryandesign (Ryan Carsten Schmidt)]

proposed patch

[ryandesign (Ryan Carsten Schmidt)]

Or neither of those. ("eval ... [glob ...]" would work if MacPorts' ln supported creating multiple links at once, like the shell's ln does, but it doesn't seem to.) The attached patch uses a "foreach ... [glob ...]" and seems to work. Perhaps this should be committed together with the fix in #29706.

[ryandesign (Ryan Carsten Schmidt)]

No wait, this patch is wrong, needs to glob the files in the destroot...

[ryandesign (Ryan Carsten Schmidt)]

fixed proposed patch

[ryandesign (Ryan Carsten Schmidt)]

Here's the fixed version.

[singingwolfboy@…]

Thanks! Verifying your patch on my computer now: it if builds cleanly and fixes the issue, I'll commit it.

[singingwolfboy@…]

Committed in r79186.