Opened 13 years ago

Last modified 7 years ago

#29852 new enhancement

php-eaccelerator - port conflicts and enhancements

Reported by: BjarneDMat Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: php-eaccelerator

Description

php5-apc
php5-xcache
php5-eaccelerator

seem to conflict with each other. at the very least the first two explicitly conflict as xcache detects the presense of apc upon loading of the extension.


add default configuration to the eaccelerator.ini file
### REQUIRES ### the proposed enhancement from #29849

Attachments (2)

php_default.ini (131 bytes) - added by BjarneDMat 13 years ago.
patch-Portfile (2.0 KB) - added by BjarneDMat 13 years ago.

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by BjarneDMat

Attachment: php_default.ini added

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Keywords: haspatch added
Port: php5-eaccelerator added
Version: 1.9.2

Please remember to fill in the Port field.

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Why do we need to exec sed? Tcl has many built-in functions for dealing with regular expressions; wouldn't one of them suffice?

file mkdir followed by file attributes can be simplified into just xinstall -d -m.

comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…

You've only added the conflicts line to php5-eaccelerator, but if we're doing to do that, then we would want to add it to php5-apc and php5-xcache too.

comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Oh I see, you submitted those separately.

php5-apc modifications submitted in #29850
php5-xcache modifications submitted in #29851

comment:5 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Conflict markers added in r79534. That still leaves the ini file modifications.

Changed 13 years ago by BjarneDMat

Attachment: patch-Portfile added

comment:6 Changed 13 years ago by BjarneDMat

1) sed :
I've looked at the tcl string functions, but I can't see something that can do what my sed command does:

  1. find only the line containing /string/ <- this is the crucial thing
  2. make the extraction

2) file mkdir & file attributes <-> xinstall -d -m :
I don't want those directories to be part of the hardlinking process that I understand Macports uses as they are used by eaccelerator for cache and log files. But if files stored in directories created by xinstall aren't hardlinked anywhere else of course go for xinstall.

comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

There's no problem using xinstall to install directories into which log files or cache files will go; many ports do that. Of course you'll want to ensure you make the directory inside the destroot, not outside, so that it is removed (as long as it's empty) when the port is uninstalled.

comment:8 Changed 7 years ago by jmroot (Joshua Root)

Port: php-eaccelerator added; php5-eaccelerator removed
Summary: php5-eaccelerator - port conflicts and enhancementsphp-eaccelerator - port conflicts and enhancements
Note: See TracTickets for help on using tickets.