#29899 closed enhancement (fixed)
Updates to the OLA Portfile
| Reported by: | nomis52@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | ryandesign (Ryan Carsten Schmidt), p3k (Tobi Schäfer), mf2k (Frank Schima) |
| Port: | ola |
Description (last modified by mf2k (Frank Schima))
This does the following:
- adds support for libusb
- sorts depends_lib
- fixes the description
- add GPL to the license
Attachments (1)
Change History (8)
Changed 13 years ago by nomis52@…
comment:1 Changed 13 years ago by mf2k (Frank Schima)
| Cc: | ryandesign@… interface@… removed |
|---|---|
| Description: | modified (diff) |
| Keywords: | haspatch maintainer added |
| Type: | update → enhancement |
| Version: | 1.9.2 |
comment:2 Changed 13 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… interface@… added |
|---|
Why did you un-Cc the port's comaintainer? I didn't mind being Cc'd either, since I had committed everything for these ports up to now, and had some input about this patch, which I've now sent to the mailing list instead.
comment:4 Changed 13 years ago by mf2k (Frank Schima)
Sorry, I think I must have removed the Cc emails by mistake because I can't think of a good reason for doing that. I agree the python variant needs work. I bumped the revision per your comments. r79652.
comment:5 follow-up: 6 Changed 13 years ago by nomis52@…
I don't quite understand the python problem. Do you mind explaining it or pointing to a port in a similar situation?
comment:6 Changed 13 years ago by mf2k (Frank Schima)
Replying to nomis52@…:
I don't quite understand the python problem. Do you mind explaining it or pointing to a port in a similar situation?
The problem is that the variant needs to depend on a specific version of python otherwise the port will depend on a random version of python and if that version is uninstalled, then ola +python will not work. So what needs to be changed is that variants must be added for each version of python supported. For example, python26, python27, python31, etc. At least supporting python26 and python27 at first would be good enough. Then add dependencies based on the specific version of python. Finally, you need to specify the directory(s) for the python library(s) based on the version of python. Many ports do this, but you can look at the mesa or qgis ports for an example. I hope that's clear. I think follow-ups should move to the macports-developers mailing list though.
r79639