libiconv @1.13.1 install error ("shell command failed" on patch)

[daniel.c.ritchie@…]

Trying to install libiconv (dependency for opencv), but some patch is failing. Here's the log:

version:1
:debug:clean Attempting ln -sf /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work /opt/local/var/macports/sources/rsync.macports.org/release/ports/textproc/libiconv/work
:debug:main Executing org.macports.main (libiconv)
:msg:main --->  Fetching libiconv
:debug:fetch fetch phase started at Sun Jul  3 18:01:46 PDT 2011
:debug:fetch Executing org.macports.fetch (libiconv)
:info:fetch --->  libiconv-1.13.1.tar.gz doesn't seem to exist in /opt/local/var/macports/distfiles/libiconv
:debug:fetch Pinging mirrors.ibiblio.org...
:debug:fetch Pinging mirrors.kernel.org...
:debug:fetch Pinging mirror.facebook.net...
:debug:fetch Pinging ftp.funet.fi...
:debug:fetch Pinging ftp.kddlabs.co.jp...
:debug:fetch Pinging ftp.dti.ad.jp...
:debug:fetch Pinging ftp.informatik.hu-berlin.de...
:debug:fetch Pinging ftp.lip6.fr...
:debug:fetch Pinging ftp.chg.ru...
:debug:fetch Pinging mirror.internode.on.net...
:debug:fetch Pinging mirror.aarnet.edu.au...
:debug:fetch Pinging ftp.gnu.org...
:debug:fetch Pinging distfiles.macports.org...
:debug:fetch Pinging aarnet.au.distfiles.macports.org...
:debug:fetch Pinging lil.fr.distfiles.macports.org...
:debug:fetch Pinging sea.us.distfiles.macports.org...
:debug:fetch Pinging ykf.ca.distfiles.macports.org...
:debug:fetch mirrors.ibiblio.org ping time is 100.104
:debug:fetch mirrors.kernel.org ping time is 13.285
:debug:fetch mirror.facebook.net ping time is 12.337
:debug:fetch ftp.funet.fi ping time is 205.401
:debug:fetch ftp.kddlabs.co.jp ping time is 10000
:debug:fetch ftp.dti.ad.jp ping time is 127.737
:debug:fetch ftp.informatik.hu-berlin.de ping time is 10000
:debug:fetch ftp.lip6.fr ping time is 172.588
:debug:fetch ftp.chg.ru ping time is 10000
:debug:fetch mirror.internode.on.net ping time is 202.908
:debug:fetch mirror.aarnet.edu.au ping time is 183.101
:debug:fetch ftp.gnu.org ping time is 10000
:debug:fetch distfiles.macports.org ping time is 17.507
:debug:fetch aarnet.au.distfiles.macports.org ping time is 186.132
:debug:fetch lil.fr.distfiles.macports.org ping time is 176.875
:debug:fetch sea.us.distfiles.macports.org ping time is 10000
:debug:fetch ykf.ca.distfiles.macports.org ping time is 102.012
:msg:fetch --->  Attempting to fetch libiconv-1.13.1.tar.gz from http://mirror.facebook.net/gnu/gnu/libiconv
:msg:fetch --->  Verifying checksum(s) for libiconv
:debug:checksum checksum phase started at Sun Jul  3 18:01:51 PDT 2011
:debug:checksum Executing org.macports.checksum (libiconv)
:info:checksum --->  Checksumming libiconv-1.13.1.tar.gz
:debug:checksum Correct (md5) checksum for libiconv-1.13.1.tar.gz
:debug:checksum Correct (sha1) checksum for libiconv-1.13.1.tar.gz
:debug:checksum Correct (rmd160) checksum for libiconv-1.13.1.tar.gz
:msg:checksum --->  Extracting libiconv
:debug:extract extract phase started at Sun Jul  3 18:01:51 PDT 2011
:debug:extract Executing org.macports.extract (libiconv)
:info:extract --->  Extracting libiconv-1.13.1.tar.gz
:debug:extract setting option extract.args to '/opt/local/var/macports/distfiles/libiconv/libiconv-1.13.1.tar.gz'
:debug:extract Environment: CPATH='/opt/local/include' CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/.CC_PRINT_OPTIONS' LIBRARY_PATH='/opt/local/lib' CC_PRINT_OPTIONS='YES' MACOSX_DEPLOYMENT_TARGET='10.6'
:debug:extract Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work" && /usr/bin/gzip -dc '/opt/local/var/macports/distfiles/libiconv/libiconv-1.13.1.tar.gz' | /usr/bin/gnutar --no-same-owner -xf -'
:debug:patch patch phase started at Sun Jul  3 18:01:58 PDT 2011
:debug:patch Executing org.macports.patch (libiconv)
:msg:patch --->  Applying patches to libiconv
:info:patch --->  Applying /opt/local/var/macports/sources/rsync.macports.org/release/ports/textproc/libiconv/files/patch-utf8mac.diff
:debug:patch Environment: CPATH='/opt/local/include' CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/.CC_PRINT_OPTIONS' LIBRARY_PATH='/opt/local/lib' CC_PRINT_OPTIONS='YES' MACOSX_DEPLOYMENT_TARGET='10.6'
:debug:patch Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/libiconv-1.13.1" && /usr/bin/patch -p1'
:info:patch patching file lib/converters.h
:info:patch patching file lib/encodings.def
:info:patch patching file lib/utf8mac.h
:info:patch --->  Applying /opt/local/var/macports/sources/rsync.macports.org/release/ports/textproc/libiconv/files/patch-src-Makefile.in-darwin.diff
:debug:patch Environment: CPATH='/opt/local/include' CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/.CC_PRINT_OPTIONS' LIBRARY_PATH='/opt/local/lib' CC_PRINT_OPTIONS='YES' MACOSX_DEPLOYMENT_TARGET='10.6'
:debug:patch Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/libiconv-1.13.1" && /usr/bin/patch -p1'
:info:patch patching file src/Makefile.in
:info:patch --->  Applying /opt/local/var/macports/sources/rsync.macports.org/release/ports/textproc/libiconv/files/patch-c99.diff
:debug:patch Environment: CPATH='/opt/local/include' CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/.CC_PRINT_OPTIONS' LIBRARY_PATH='/opt/local/lib' CC_PRINT_OPTIONS='YES' MACOSX_DEPLOYMENT_TARGET='10.6'
:debug:patch Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/libiconv-1.13.1" && /usr/bin/patch -p1'
:info:patch can't find file to patch at input line 3
:info:patch Perhaps you used the wrong -p or --strip option?
:info:patch The text leading up to this was:
:info:patch --------------------------
:info:patch |--- lib/iconv.c.orig	2011-07-03 10:09:20.000000000 -0700
:info:patch |+++ lib/iconv.c	2011-07-03 10:11:24.000000000 -0700
:info:patch --------------------------
:info:patch File to patch: 
:info:patch Skip this patch? [y] 
:info:patch Skipping patch.
:info:patch 1 out of 1 hunk ignored
:info:patch shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/work/libiconv-1.13.1" && /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/release/ports/textproc/libiconv/files/patch-c99.diff'" returned error 1
:error:patch Target org.macports.patch returned: shell command failed (see log for details)
:debug:patch Backtrace: shell command failed (see log for details)
    while executing
"command_exec patch "" "< '$patch'""
    (procedure "portpatch::patch_main" line 35)
    invoked from within
"$procedure $targetname"
:info:patch Warning: the following items did not execute (for libiconv): org.macports.activate org.macports.patch org.macports.configure org.macports.build org.macports.destroot org.macports.install
:error:patch Failed to install libiconv
:notice:patch Log for libiconv is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_textproc_libiconv/main.log
 

[jmroot (Joshua Root)]

Please remember to fill in the Port field and cc the maintainer.

[glennra (Glenn Ramsey)]

Cc Me!

[jpr5@…]

Same here.

From the logs looks like a simply patch apply fail (target file is missing? in wrong dir when patch applied maybe?), but FWIW I'm on 10.7.

[jpr5@…]

Looks like a patch was added that necessitated -p1:

# Use -p1 to accommodate the cp932fix patch
patch.pre_args -p1
patchfiles \
    patch-utf8mac.diff \
    patch-src-Makefile.in-darwin.diff \
    patch-c99.diff

But p1 is clearly not compatible with all of the patches.

[ryandesign (Ryan Carsten Schmidt)]

Caused by r80075.

[jpr5@…]

Fix is to the diff itself, just add a/b prefixes:

files/patch-c99.diff

@@ -1 @@
---- lib/iconv.c.orig    2011-07-03 10:09:20.000000000 -0700
-+++ lib/iconv.c 2011-07-03 10:11:24.000000000 -0700
+--- a/lib/iconv.c.orig  2011-07-03 10:09:20.000000000 -0700
++++ b/lib/iconv.c       2011-07-03 10:11:24.000000000 -0700
 @@ -172,7 +172,9 @@ static const struct alias sysdep_aliases
  #include "aliases2.h"
  #undef S

[ryandesign (Ryan Carsten Schmidt)]

Fixed in r80094.

[jpr5@…]

Cc Me!

[jpr5@…]

Er, awesome. Thanks!

[jeremyhu (Jeremy Huddleston Sequoia)]

Ugg sorry. I think I missed it because the Portfile didn't change between revisions, so it didn't actually apply the patch. Sorry for the noise.