Opened 13 years ago

Closed 13 years ago

#30035 closed defect (fixed)

vpnc update to make it work in mac os x 10.7

Reported by: tk7r (Thomas Kotzian) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc:
Port: vpnc

Description

vpnc does not compile on mac os x 10.7 because definitions of the function getline clash. mac os x 10.5/10.6 do not have a getline function so vpnc defines its own. mac os x 10.7 has a getline and vpnc has to be told about it. please find the port and patch file attached. tested on 10.7 (GM) and 10.6.8

Attachments (2)

Portfile (1.8 KB) - added by tk7r (Thomas Kotzian) 13 years ago.
Portfile (update revision, add patch file)
patch-sysdep.h (375 bytes) - added by tk7r (Thomas Kotzian) 13 years ago.
patch file

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by tk7r (Thomas Kotzian)

Attachment: Portfile added

Portfile (update revision, add patch file)

Changed 13 years ago by tk7r (Thomas Kotzian)

Attachment: patch-sysdep.h added

patch file

comment:1 Changed 13 years ago by mf2k (Frank Schima)

Please attach a patch of the Portfile as a universal diff.

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

If the build does not work before this patch on 10.7, then there is no justification for increasing the port's revision.

comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

It seems wrong to base this check on #ifdef __MAC_10_7; one should check for features, not OS versions. But I committed it in r80159 as is since you say it resolve the problem for now, and hopefully the next version of vpnc will fix it the right way. (Have you already reported the problem to the developers of vpnc? If not, please do so.)

Note: See TracTickets for help on using tickets.