Opened 13 years ago
Closed 13 years ago
#30095 closed defect (fixed)
fping on 10.7
| Reported by: | tk7r (Thomas Kotzian) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.99 |
| Keywords: | lion haspatch | Cc: | smparkes@… |
| Port: | fping |
Description
a little patch to Makefile.in to make fping compile on Mac OS X 10.7
Attachments (4)
Change History (12)
Changed 13 years ago by tk7r (Thomas Kotzian)
| Attachment: | fping-Makefile.in.patch added |
|---|
Changed 13 years ago by tk7r (Thomas Kotzian)
| Attachment: | patch-Makefile.in.diff added |
|---|
patch file - renamed - matches Portfile
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|
Does fping not compile on 10.7 as is? (What happens? Can we see the main.log?)
Does this patch change anything about how fping works on 10.6 and earlier?
If the answer to the first question is yes and the answer to the second question is no then you do not need to increase the port's revision.
comment:2 Changed 13 years ago by tk7r (Thomas Kotzian)
i have created the patch because it doesn't compile. some constants are not defined as in 10.6. see the file /usr/include/netinet6/in6.h and search for __APPLE_USE_RFC_3542 and __APPLE_USE_RFC_2292 - i can't copy and paste the content of this file. you have to define one of the constants 2292 is the older one and 3542 the newer one. - but no default one. the user has to choose.
Changed 13 years ago by tk7r (Thomas Kotzian)
main.log file of failed build
comment:4 Changed 13 years ago by nerdling (Jeremy Lavergne)
| Keywords: | lion added |
|---|
comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | thomas.kotzian@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to ryandesign@… |
| Status: | new → assigned |
comment:8 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I have committed a version of this patch in r81859 along with several other changes including one to ensure the port is UsingTheRightCompiler. Previously it would always use gcc even when the user has Xcode 4.x where our preferred compilers are llvm-gcc (Xcode 4.0.x and 4.1.x) or clang (Xcode 4.2+). However it's possible that this change also breaks the build on Lion. (I don't have Lion to test with yet.) Please let me know if you experience any problems building fping @2.4b2_1 and if so what version of Xcode you have.
fping source Patch