#30173 closed enhancement (fixed)
mod_chroot - cleanup
Reported by: | miwi@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.9.2 |
Keywords: | haspatch maintainer | Cc: | |
Port: | mod_chroot |
Description
Hi,
Remove all whitespaces
Attachments (1)
Change History (5)
Changed 13 years ago by miwi@…
Attachment: | mod_chroot.diff added |
---|
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | maintainer added |
---|---|
Owner: | changed from macports-tickets@… to ryandesign@… |
Status: | new → assigned |
comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Committed in r80539 and r80540 with some changes. Your patch had the second column indented at 19 characters, and the destroot block's contents indented at 9 characters, while we want indents to occur at multiples of 4 characters as the modeline says. I re-indented your patch to put the second column at 20 characters and the destroot block's contents at 4 characters.
comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Type: | update → enhancement |
---|
comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
There was a syntax error in the master_sites line of your patch which I fixed in r80541.
Note: See
TracTickets for help on using
tickets.
Thanks. Note that the diff you attached is for many ports; I'll just take a look at the portions related to the mod_chroot port. You were probably in the "www" directory instead of the "mod_chroot" directory when you issued "svn diff". Remember to check the diff before submitting to ensure it's what you intend us to commit.
Also, note that "whitespace" means "any single character or series of characters that represents horizontal or vertical space"; as such, your patch cannot be said to "remove all whitespaces"; rather, it changes the whitespace of the portfile, specifically it changes the horizontal whitespace from mostly tab characters to all space characters, which brings the port more in line with our recommended style. When such a change is made, we usually also add the standard modeline in the same commit.