#30312 closed defect (fixed)
clang cannot compile ncurses
| Reported by: | Veence (Vincent) | Owned by: | jmroot (Joshua Root) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.0 |
| Keywords: | clang | Cc: | |
| Port: | ncurses |
Description (last modified by Veence (Vincent))
The clang++ compiler does not compile ncurses 1.9 because of a mistake between
NCursesUserForm (NCursesFormField* Fields[],…) and NCursesUserForm (NCursesFormField Fields[],
in cursesm.h and cursesf.h.
Apparently, since these objects are never instantiated, GCC does not complain about the type mismatch, whereas clang is more correct.
I join two patches that fix this inconsistency. Please update the portfile accordingly.
Attachments (2)
Change History (7)
Changed 13 years ago by Veence (Vincent)
| Attachment: | patch-cursesf_h.diff added |
|---|
Changed 13 years ago by Veence (Vincent)
| Attachment: | patch-cursesm_h.diff added |
|---|
Patch for cursesm.h
comment:1 Changed 13 years ago by Veence (Vincent)
| Description: | modified (diff) |
|---|---|
| Summary: | clang cannot compile nurses → clang cannot compile ncurses |
comment:2 Changed 13 years ago by jmroot (Joshua Root)
| Cc: | jmr@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to jmr@… |
| Status: | new → assigned |
Have you sent these upstream? Also, shouldn't you be able to assign tickets?
comment:3 Changed 13 years ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 Changed 13 years ago by Veence (Vincent)
Sorry, I was a bit in hurry when I registered this ticket (I was on my way to my holiday resort :)), maybe I should have waited till tonight. No, I have not contacted the people upstream, if you want, I can do it. I wonder how this error has gone unnoticed for such a long time.
comment:5 Changed 13 years ago by jmroot (Joshua Root)
I'll send it upstream, I just didn't want to do it again if you already had. Thanks.
Patch for cursesf.h