root @5.30.00, Revision 1 build fails on OS X Lion

[cdeil (Christoph Deil)]

See attached log.

:info:build make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root/root/work/root'
:info:build bin/rmkdepend -R -fnet/rpdutils/src/rpdconn.d -Y -w 1000 -- -m64 -pipe -Wshadow -W -Wall -Woverloaded-virtual -fsigned-char -fno-common -Iinclude -DR__HAVE_CONFIG   -pthread -D__cplusplus -- /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root/root/work/root/net/rpdutils/src/rpdconn.cxx
:info:build /Developer/usr/bin/llvm-g++-4.2 -O2 -m64 -pipe -Wshadow -W -Wall -Woverloaded-virtual -fsigned-char -fno-common -Iinclude -DR__HAVE_CONFIG   -pthread -o net/rpdutils/src/rpdconn.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root/root/work/root/net/rpdutils/src/rpdconn.cxx
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root/root/work/root/net/rpdutils/src/rpdconn.cxx: In member function ‘int rpdconn::senddesc(int)’:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root/root/work/root/net/rpdutils/src/rpdconn.cxx:398: error: size of array ‘buf’ is not an integral constant-expression
:info:build make: *** [net/rpdutils/src/rpdconn.o] Error 1

[ryandesign (Ryan Carsten Schmidt)]

Please fill in Port and Cc field

[g5pw (Aljaž Srebrnič)]

Cc Me!

[cjones051073 (Chris Jones)]

I suspect the upstream ROOT developers haven't yet tested on Lion, so we may need to wait until they do for full support. I don't have a Lion machine myself (and won't be upgrading for a while, until a few applications I need are supported on Lion) so cannot test anything myself...

That said, it looks like the problem is coming from the fact you are using the sys llvm compiler. Could you try building with one of the gcc variants (gcc44 or gcc45) and see if that helps ?

Chris

[cdeil (Christoph Deil)]

The root +gcc44 variant works with Lion. Thank's for the tip.

[cjones051073 (Chris Jones)]

Good to hear.

There is another report on the root mailing list from a Lion user, who failed to build root from source (tarball). gcc is really the main compiler at CERN, so I am not at all surprised to see problems with other compilers.

I have no idea how quickly this will get fixed, but if I had to guess I would say a while. Maybe we should make gcc44 (or gcc45) the default compiler, for the moment at least ?

Chris

[mf2k (Frank Schima)]

Cc Me!

[cjones051073 (Chris Jones)]

I've had a discussion with the ROOT devs on their mailing list.

Turns out I did them a little disservice suggesting they haven't looked at Lion yet. Turns out they have, and some fixes are already submitted to their trunk version, and they plan to make a release with them by the end of the week. I won't be able to test on Lion myself, but assuming the update works fine for me on 10.6, I'll submit an update for testing once its out.

Chris

[go.iwai@…]

Cc Me!

[mattiafrancescomoro@…]

i have some free time now and i look after a new variant with only qt and no X11 (so there are less dependencies) also, many deps have too many unused variants.

[justin.garofoli@…]

I got it to work with the following:

#> sudo port -vf install root +gcc44 +python26

after that I had an import error:

#>python
Python 2.6.7 (r267:88850, Aug 18 2011, 08:03:41) 
[GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ROOT
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/site-packages/ROOT.py", line 85, in <module>
    import libPyROOT as _root
ImportError: No module named libPyROOT
>>>

which I fixed with a tip from here (​https://bugs.launchpad.net/ubuntu/+source/root-system/+bug/512600):

#>python
Python 2.6.7 (r267:88850, Aug 18 2011, 08:03:41) 
[GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.path.append('/opt/local/lib/root/')
>>> import ROOT
>>> br = ROOT.TBrowser()
>>>

[justin.garofoli@…]

Cc Me!

[cdeil (Christoph Deil)]

I downloaded the current patch release via

svn co http://root.cern.ch/svn/root/branches/v5-30-00-patches root

(see ​http://root.cern.ch/drupal/content/root-version-v5-30-00-patch-release-notes) and successfully built it on Lion with

./configure && make

Guess to be able to use it from MacPorts we have to wait for CERN to make a tarball?

[jmroot (Joshua Root)]

In the meantime, you could change configure.compiler in the portfile. See: ​http://lists.macosforge.org/pipermail/macports-dev/2011-July/015263.html

[ryandesign (Ryan Carsten Schmidt)]

The root port has been updated to 5.30.01. Does that help?

[cjones051073 (Chris Jones)]

I've just updated my patch for v5.30.01 that changes the libdir directory that is used, that might fix the python variant issues (why, I am not entirely sure, but worked for me in a few tests....).

[cdeil (Christoph Deil)]

Thanks a lot!

Now root builds successfully with the default gcc (llvm-g++-4.2), I no longer have to select the gcc44 variant. Also pyROOT builds successfully, so you can close ticket #23856 as well.

For others that want to use pyROOT you have to add /opt/local/lib/root/ to your PYTHONPATH, if you don't you'll get an ImportError: No module named libPyROOT

Maybe this tip can be printed as a tip to the user by macports when someone installs a python variant?

[cjones051073 (Chris Jones)]

You are right about needing to add /opt/local/lib/root to PYTHONPATH. I had this in my ~/.profile and had forgotten about it.

Is it enough to just add a comment during the build, and let the user do this themselves, or is the a way the build can add this itself ?

[cdeil (Christoph Deil)]

Replying to jonesc@…:

Is it enough to just add a comment during the build, and let the user do this themselves, or is the a way the build can add this itself ?

I don't know. In principle I guess Macports could put libPyROOT somewhere else, e.g. directly besides ROOT.py (there must be other python ports with a similar problem)? I don't think Macports can modify PYTHONPATH?

For me the message to the user would be just fine.

[ryandesign (Ryan Carsten Schmidt)]

Is this ticket still applicable now that root has been updated to 5.30.02?

[cjones051073 (Chris Jones)]

ROOT builds natively on Lion since 5.30.01, so that part of the above discussion can be closed as fixed.

The python variants should also be fixed. I can build them all (with various combinations of compilers) on my OS X 10.7 system. I don't have a 10.6 system to test on anymore, but I am pretty confident it should be fixed there to (if someone with 10.6 wouldn't mind trying to build the various python variants to check, that would be great).

I confess I forgot about the suggestion above to print a message about adding to PYTHONPATH. I'll do this in a future update.

[mf2k (Frank Schima)]

I can confirm that the +python26 variant works on Snow Leopard. After adjusting the python path of course.

[mf2k (Frank Schima)]

I'm going to called this fixed for now.

[cjones051073 (Chris Jones)]

what exactly do you mean by "After adjusting the python path of course" ?

[cjones051073 (Chris Jones)]

Sorry... approximately 2 secs after sending that last post I realised you most likely mean after adding /opt/local/lib/root to PYTHONPATH ...