Opened 13 years ago

Closed 13 years ago

#30336 closed defect (fixed)

arpack g95 variant

Reported by: tenomoto (Takeshi Enomoto) Owned by: mamoll (Mark Moll)
Priority: Normal Milestone:
Component: ports Version: 2.0.0
Keywords: Cc:
Port: arpack

Description

A patch is attached to resurrect g95 variant, deleted in r68322 (cf. #25066). If accelerate variant is not used (default) atlas should be in depends_lib. I might have sent a similar patch but I could not find it. So I created a ticket.

Attachments (3)

Portfile.diff (3.7 KB) - added by tenomoto (Takeshi Enomoto) 13 years ago.
Portfile_accelerate.diff (3.7 KB) - added by tenomoto (Takeshi Enomoto) 13 years ago.
Portfile.patch (391 bytes) - added by tenomoto (Takeshi Enomoto) 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by tenomoto (Takeshi Enomoto)

Attachment: Portfile.diff added

comment:1 Changed 13 years ago by mamoll (Mark Moll)

Why are you adding atlas as a dependency and then not use it (by default) for g95? Is there really any benefit of using atlas over the system-wide LAPACK? I think atlas should at best be a variant that is disabled by default and can probably be omitted.

comment:2 Changed 13 years ago by tenomoto (Takeshi Enomoto)

I agree with you. I prefer Accelerate.framework that comes with Mac OS X.

atlas has been the default for a while in various ports to avoid the problem of CDOTC CDOTU ZDOTC and ZDOTU in BLAS (see Accelerate.framework errata with g95 and 64-bit gfortran. Using wrappers is a workaround to this problem. I wrote dotwrp and dotwrp port.

In fact arpack does not seem to use CDOTC CDOTU ZDOTC and ZDOTU so there is no problem to use accelerate variant as a default.

I attach another patch for accelerate as the default. It is your choice. (Or should we discuss this in MacPorts Development ML?)

Changed 13 years ago by tenomoto (Takeshi Enomoto)

Attachment: Portfile_accelerate.diff added

comment:3 Changed 13 years ago by mamoll (Mark Moll)

Resolution: fixed
Status: newclosed

I committed your last patch with slight modifications. See r82047.

Changed 13 years ago by tenomoto (Takeshi Enomoto)

Attachment: Portfile.patch added

comment:4 Changed 13 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: closedreopened

Since dylib is not created with +g95 shlib needs to be empty.

comment:5 Changed 13 years ago by mamoll (Mark Moll)

Resolution: fixed
Status: reopenedclosed

Oops, sorry. Fixed in r83641.

Note: See TracTickets for help on using tickets.