Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#30650 closed submission (fixed)

shell-fm submission

Reported by: felix@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.0.1
Keywords: Cc:
Port: shell-fm

Description

new submission for shell-fm.

I have permission from the author of the program to release onto macports.

Thanks.

Attachments (2)

Portfile (1.2 KB) - added by felix@… 13 years ago.
Portfile.2 (2.0 KB) - added by felix@… 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by felix@…

Attachment: Portfile added

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: shell-fm added
Status: newassigned

Thank you, I will try to clean this up and commit it.

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Added in r82139 with these changes:

  • Converted tabs to spaces to conform with the modeline
  • Added dependencies on pkgconfig, taglib, libmad
  • Used official 0.8 tarball (with some patches) instead of your own "0.8.1" version; your version appeared to be the head of the repository plus a few additional changes; please submit those additional changes to the developer if you want them included
  • Ensured we're UsingTheRightCompiler and build_arch
  • Indicated the license
  • Fixed the livecheck

comment:3 Changed 13 years ago by felix@…

noticed that there some problems in the description of the port, fixed and re-uploaded.

Changed 13 years ago by felix@…

Attachment: Portfile.2 added

comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

What is the problem with the description? In your new Portfile, you only appear to be changing UTF-8 smart quotes to regular quotes (smart quotes should be fine, and look prettier), reinstating a parenthetical about the size of the binary that I had removed (because the estimate was not accurate, and you can't really know what size the binary will be because you don't know for what architectures the user will choose to build it—the port doesn't currently have a universal variant but I'll try to add one), and adding some whitespace that I don't think needs to be added. In the future, if you want changes made to a port, please attach a diff so it is more easy to see what changes you propose.

comment:5 Changed 13 years ago by felix@…

oh, my bad. i thought the smart quotes would mess up formatting in macports/the shell. the size of the binary was a oversight on my part. will do, didn't know i should attach a diff file for changes/patches.

Note: See TracTickets for help on using tickets.