Opened 13 years ago

Closed 13 years ago

#30674 closed enhancement (fixed)

unify py*-numpy and py*-scipy

Reported by: jmroot (Joshua Root) Owned by: skymoo (Adam Mercer)
Priority: Normal Milestone:
Component: ports Version: 2.0.1
Keywords: Cc: Veence (Vincent), dh@…
Port: py-numpy py25-numpy py26-numpy py27-numpy py31-numpy py32-numpy py-scipy py25-scipy py26-scipy py27-scipy py31-scipy py32-scipy

Description

With six different python versions supported, these ports are perfect candidates for combining into a single portfile per module.

Attachments (2)

Portfile​ (6.1 KB) - added by skymoo (Adam Mercer) 13 years ago.
unified Portfile for py*-numpy
Portfile.2​ (5.2 KB) - added by skymoo (Adam Mercer) 13 years ago.
unified portfile for py*-scipy

Download all attachments as: .zip

Change History (13)

comment:1 Changed 13 years ago by skymoo (Adam Mercer)

You mean using subports? That will make maintenance a lot easier. Is there an existing example of how that works?

comment:2 Changed 13 years ago by jmroot (Joshua Root)

Existing unified python ports are: py-altgraph, py-amqplib, py-bdist_mpkg, py-blist, py-kombu, py-macholib, py-modulegraph, py-numeric, py-pika, py-pil, py-sympy.

comment:3 Changed 13 years ago by skymoo (Adam Mercer)

Thanks, I'll take a look.

comment:4 Changed 13 years ago by skymoo (Adam Mercer)

Attached is a unified Portfile for py*-numpy, I would be obliged if someone could test the universal variant? The patches can be taken from py27-numpy/files, for example.

comment:5 Changed 13 years ago by jmroot (Joshua Root)

Note that nose has now been unified, so you don't need to special case the dependency. There are a number of things being done unconditionally in this portfile that will cause the py-numpy stub port to fail. Easiest fix would be to just put everything between checksums and livecheck inside an if {$subport != $name} block.

comment:6 Changed 13 years ago by skymoo (Adam Mercer)

Thanks for the comments, you mean like the updated attachment?

Changed 13 years ago by skymoo (Adam Mercer)

Attachment: Portfile​ added

unified Portfile for py*-numpy

comment:7 Changed 13 years ago by jmroot (Joshua Root)

Yes, looks good now.

comment:8 Changed 13 years ago by skymoo (Adam Mercer)

numpy port pushed in r83852, onto scipy...

Changed 13 years ago by skymoo (Adam Mercer)

Attachment: Portfile.2​ added

unified portfile for py*-scipy

comment:9 Changed 13 years ago by skymoo (Adam Mercer)

I've attached a unified Portfile for scipy, can anyone see any problems with this?

comment:10 Changed 13 years ago by skymoo (Adam Mercer)

Cc: ram@… removed
Owner: changed from macports-tickets@… to ram@…
Status: new → assigned

comment:11 Changed 13 years ago by skymoo (Adam Mercer)

Resolution: → fixed
Status: assigned → closed

unified scipy committed in r84336

Note: See TracTickets for help on using tickets.