Opened 13 years ago

Closed 13 years ago

#30704 closed enhancement (fixed)

git-core: support Perl-compatible regexes

Reported by: carsomyr@… Owned by: maccheck@…
Priority: Normal Milestone:
Component: ports Version: 2.0.99
Keywords: haspatch Cc: neverpanic (Clemens Lang)
Port: git-core

Description

When trying to use "git grep" with the "-P" option, I get

cannot use Perl-compatible regexes when not compiled with USE_LIBPCRE

I've attached a patch that adds PCRE support through the pcre Port.

Attachments (2)

Portfile (6.1 KB) - added by carsomyr@… 13 years ago.
The Portfile (revision 2).
patch-Portfile.diff (803 bytes) - added by carsomyr@… 13 years ago.
The Portfile patch (revision 3).

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by carsomyr@…

I've reattached the Portfile to reflect underlying changes to the git-core Port.

Changed 13 years ago by carsomyr@…

Attachment: Portfile added

The Portfile (revision 2).

comment:2 Changed 13 years ago by neverpanic (Clemens Lang)

Cc: cal@… added; maccheck@… removed
Owner: changed from macports-tickets@… to maccheck@…

I wonder whether we should make this a variant, or add it by default.

Changed 13 years ago by carsomyr@…

Attachment: patch-Portfile.diff added

The Portfile patch (revision 3).

comment:3 in reply to:  2 Changed 13 years ago by carsomyr@…

Good point! I've reattached patch-Portfile.diff. libpcre support is now a variant. Please rebuild and see if "git grep -P" works (if libpcre support isn't there, then git will just complain and do nothing).

Replying to cal@…:

I wonder whether we should make this a variant, or add it by default.

comment:4 Changed 13 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Commited in r83536.

Note: See TracTickets for help on using tickets.