Opened 13 years ago
Closed 13 years ago
#30781 closed defect (fixed)
Small change to qt4-mac and qt4-mac-devel Portfiles
| Reported by: | carsomyr@… | Owned by: | michaelld (Michael Dickens) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.99 |
| Keywords: | haspatch | Cc: | |
| Port: | qt4-mac, qt4-mac-devel |
Description
When browsing the Portfiles for qt4-mac and qt4-mac-devel, I found that the minor Mac OS X version detection could be improved so that it behaves as the author intended. Please find attached the Portfile patch.
Attachments (1)
Change History (5)
Changed 13 years ago by carsomyr@…
| Attachment: | Portfile.diff added |
|---|
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | michaelld@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to michaelld@… |
comment:2 follow-up: 3 Changed 13 years ago by jmroot (Joshua Root)
That whole thing is actually unnecessary. If you're not on Darwin, it's going to produce a nonsense MDT from os.version, and if you are on Darwin, macosx_deployment_target is always set.
comment:3 Changed 13 years ago by michaelld (Michael Dickens)
Replying to jmr@…:
That whole thing is actually unnecessary. If you're not on Darwin, it's going to produce a nonsense MDT from os.version, and if you are on Darwin, macosx_deployment_target is always set.
So, since qt4-mac is intended for building Darwin only: os.version should not be used, and instead I should just use macosx_deployment_target? I can easily make that change & the correction from this ticket as well.
comment:4 Changed 13 years ago by michaelld (Michael Dickens)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The Portfile patch.